New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle onmount callbacks correctly when render conditionally #26

Merged

Bloomca merged 1 commit into main from handle-onmount-callbacks-correctly

Jun 3, 2024

Owner

Bloomca commented Jun 3, 2024

Description

The previous implementation of mount handlers was a bit hacky, and also it was not working correctly for 2 reasons:

it would try to trigger mount callbacks even if the result tree is not mounted
it was not triggered for top level components rendered conditionally

This PR fixes it and makes it so that we execute mount callbacks right after new nodes are mounted into the DOM.


          Handle onmount callbacks correctly when render conditionally

Bloomca force-pushed the handle-onmount-callbacks-correctly branch from ed2a68a to 0324714 Compare

June 3, 2024 03:56

Bloomca merged commit 43f68c4 into main

1 check passed

Bloomca deleted the handle-onmount-callbacks-correctly branch

June 3, 2024 03:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet