Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LAPS schema #68

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Update LAPS schema #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be5818e
Added msLAPS-PasswordExpirationTime property
spyr0-sec Aug 15, 2023
1f2089b
Check for either LAPS attribute
spyr0-sec Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/CommonLib/LDAPProperties.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ public class LDAPProperties
public const string OperatingSystem = "operatingsystem";
public const string ServicePack = "operatingsystemservicepack";
public const string DNSHostName = "dnshostname";
public const string LAPSExpirationTime = "ms-mcs-admpwdexpirationtime";
public const string LAPSExpirationTime = "mslaps-passwordexpirationtime";
public const string LegacyLAPSExpirationTime = "ms-mcs-admpwdexpirationtime";
public const string Members = "member";
public const string SecurityDescriptor = "ntsecuritydescriptor";
public const string SecurityIdentifier = "securityidentifier";
Expand All @@ -48,4 +49,4 @@ public class LDAPProperties
public const string ScriptPath = "scriptpath";
public const string HostServiceAccount = "msds-hostserviceaccount";
}
}
}
4 changes: 2 additions & 2 deletions src/CommonLib/SearchResultEntryWrapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,12 +247,12 @@ public bool IsGMSA()

public bool HasLAPS()
{
return GetProperty(LDAPProperties.LAPSExpirationTime) != null;
return GetProperty(LDAPProperties.LAPSExpirationTime) != null || GetProperty(LDAPProperties.LegacyLAPSExpirationTime) != null;
}

public SearchResultEntry GetEntry()
{
return _entry;
}
}
}
}
Loading