Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect collection of ACE GUIDS from Schema #169

Merged
merged 7 commits into from
Oct 15, 2024
Merged

Incorrect collection of ACE GUIDS from Schema #169

merged 7 commits into from
Oct 15, 2024

Conversation

rvazarkar
Copy link
Contributor

@rvazarkar rvazarkar commented Oct 8, 2024

Description

The logic for checking ACE guids in the schema was incorrectly using the guid of the object instead of the SchemaGuid value. Additionally, it was not using a paged query which is required since the schema partition returns tons of objects.

Also switched to a concurrent-aware data structure for storing built domain caches

Motivation and Context

LAPS edges not being created correctly

How Has This Been Tested?

Tested in a local LAPS enabled environment

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@rvazarkar rvazarkar merged commit 48e136d into v4 Oct 15, 2024
3 checks passed
@rvazarkar rvazarkar deleted the fix_laps branch October 15, 2024 15:43
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants