Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: collect unresolved published cert templates #98

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

JonasBK
Copy link
Collaborator

@JonasBK JonasBK commented Apr 29, 2024

Description

Collect unresolved published cert templates for EnterpriseCAs and store them in a property list.

Depends on this Commonlib PR: BloodHoundAD/SharpHoundCommon#121

Motivation and Context

We want to collect the names of unresolved published cert templates, as an attacker can create or rename a cert template to have one of these names and then it will be published automatically.

How Has This Been Tested?

Collected in my lab with one EnterpriseCA with no unresolved cert templates and another with.

Screenshots (if appropriate):

image

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@JonasBK JonasBK marked this pull request as ready for review May 2, 2024 06:55
@juggernot325 juggernot325 merged commit ff7974c into 2.X May 3, 2024
1 check passed
@juggernot325 juggernot325 deleted the BED-4089 branch May 3, 2024 14:04
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants