Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node 22 and 23 to test matrix #1104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GaryWilber
Copy link
Collaborator

No description provided.

@milindl
Copy link

milindl commented Dec 11, 2024

v8 removed v8::CopyablePersistentTraits from the version of v8 used in node v23, and using Nan::CopyablePersistentTraits doesn't seem to work, it gives a template substitution error for node v18. We're trying to get around it by replacing std::vector<v8::Persistent<v8::Function, Nan::CopyablePersistentTraits<v8::Function> > > callbacks with std::vector<Nan::Callback*> callbacks;.

@aryamohanan
Copy link

Any updates on this? I’ve already opened an issue #1099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants