Skip to content
This repository has been archived by the owner on Jun 29, 2024. It is now read-only.

giga slop pr mk7 #813

Closed
wants to merge 44 commits into from
Closed

giga slop pr mk7 #813

wants to merge 44 commits into from

Conversation

JTGSZ
Copy link
Contributor

@JTGSZ JTGSZ commented May 14, 2024

IF TESTMERGING BE ON TO MONITOR THINGS

number 7 (so its lucky this time)

rewrites a ton of the triumph shit
adds triumph buy menu
merges pilgrim and adventurers into their complete hobo form
gives them a brand new selection menu w extra options
retypes beggar typepaths to beggar typepaths as im now using vagrants as a name
swaps category bools to bitflags on classes
fixes the fullscreen overlays being fucked on layers for some reason (idk happened recently)

@CVSthePharmacy
Copy link

wtf pilgrim and adventurer rolls mixed together are SO ass, do NOT keep this in

Copy link
Contributor

@Real-MAGNUM Real-MAGNUM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change these prices, and for the love of christ please change the text colors here to a unified set. Ask @Takyon69 for a pallete.
image

untestmerging

/datum/triumph_buy/wipe_triumphs
triumph_buy_id = "WipeTriumphs"
desc = "Burn down the hall of triumphs! Bring everyone back to ZERO!"
triumph_cost = 100
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
triumph_cost = 100
triumph_cost = 500

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO FUCK YOURSELF NO, 500 WOULD TAKE AN ACTUAL 5 FUCKING MONTHS, USE YOUR FUCKING HEAD

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, erasing peoples progress shouldnt be easy

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, erasing peoples progress shouldnt be easy

hey cocksucker, that's 5-6 months of work, i'd at most be ok with 150 or 175

/datum/triumph_buy/grenzelhoft_maximum
triumph_buy_id = "Grenzelhoftmaxx"
desc = "Everyone is a human from Grenzelhoft!"
triumph_cost = 30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
triumph_cost = 30
triumph_cost = 50

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAY too much for a funny gimmick

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Races have stats, its not a funny gimmick its a straight up mechanical effect
Hell it should cost more

/datum/triumph_buy/pick_any_class
triumph_buy_id = "PickAny"
desc = "Get single run of a class that can pick any class on the vagrant class selection! WARNING: MAY BE BUGGY"
triumph_cost = 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
triumph_cost = 10
triumph_cost = 2

@K4rlox
Copy link
Contributor

K4rlox commented May 15, 2024

adventurer class pick thing does not scale with PQ, it used to do so
i really think it should still do so

@WroughtPlate
Copy link

WroughtPlate commented May 15, 2024

Fewer people will comment on this. Not because it hasn't got controversial changes but probably due to its vague name (intentional?).

Good balance change on adventurers but awful in terms of what a lot of players want and enjoy. That's common enough feedback.

The new triumph system is interesting but with "seasons", it feels very MOBA-like or similar to what competitive shooters do such as Tarkov in a way I personally dislike but I'm sure there's other opinions. For now the other buy options: e.g. making everyone Grenzelhoft, sounds fun for the player doing it and not for anyone else. It will probably be funny the first time but after a few, it will get very, very old.

@Real-MAGNUM Real-MAGNUM added the DO NOT MERGE WIP or otherwise held from merge label May 15, 2024
@Real-MAGNUM
Copy link
Contributor

Real-MAGNUM commented May 15, 2024

adventurer class pick thing does not scale with PQ, it used to do so i really think it should still do so

There was supposed to be a slot-purchasing functionality that permanently (per character) increased the amount of slots purchased. However, the price is 1 and it doesn't seem to even work.

After a few upgrades you could re-roll ten slots instead of four or whatever.

@Real-MAGNUM
Copy link
Contributor

Stop making fucking meme PR names or I'll start closing them every time regardless of changes.

@Real-MAGNUM Real-MAGNUM reopened this May 15, 2024
@JTGSZ
Copy link
Contributor Author

JTGSZ commented May 15, 2024

Closing this PR as I'm going to redo a lot of stuff based on feedback/new design

@JTGSZ JTGSZ closed this May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DO NOT MERGE WIP or otherwise held from merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants