Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Expenses/RF32: Endpoint for expenseReport data by id #205

Merged
merged 9 commits into from
May 23, 2024

Conversation

Ian326
Copy link
Contributor

@Ian326 Ian326 commented May 23, 2024

Expenses-RF32: Endpoint for expenseReport data by id

[Feature/RF32]: Added an endpoint for getting expenseReport data by id. Added base logic for expenses and all of it's corresponding files

Description

RF32: As a user I want to consult the details of a travel expenses report.

Changes

  • Added prisma/migrations/20240522045959_expenses_update_fields/migration.sql. Migration to support corresponding fields for expenses according to updated ER Model
  • Modified prisma/schema.prisma as a result of the previous migration
  • Modified src/api/routes/index.routes.ts. Added endpoint for /expense/
  • Added src/api/routes/expense.routes.ts
  • Added src/api/controllers/expense.controller.ts
  • Added src/core/domain/entities/expense.entity.ts
  • Added src/core/app/services/expense.service.ts
  • Added src/core/infra/mappers/expense-entity-from-db-model.mapper.ts
  • Added src/core/infra/repositories/expense.repository.ts
  • Modified src/utils/enums/index.ts. Added enum for ExpenseReportStatus
  • Added src/core/app/services/__tests__/expense.service.test.ts for testing services

Story Points

8

Testing

A test was designed and run in which the service was tested. Mocha&Chai was used for this automated test. The test succeeds
image

Dependencies

None (It will be the PR that lays the foundation for the entire expenses module)

Done?

  • La tarea ha sido completamente implementada, cumpliendo con todos los requisitos y funcionalidades definidos.
  • Todas las pruebas pasan, siguiendo el plan de pruebas.
  • El código sigue los estándares de codificación y las mejores prácticas del proyecto.
  • La documentación ha sido actualizada (si corresponde).
  • Se han cerrado todos los issues (si aplicara) creados en el defect Log.
  • Se ha creado o actualizado la documentación necesaria relacionada con la tarea.
  • Se ha mapeado en las herramientas de trazabilidad RTM, PVG

Screenshot

image

@Ian326 Ian326 added enhancement New feature or request Zeitgeist labels May 23, 2024
@Ian326 Ian326 added this to the MBI 1.0 milestone May 23, 2024
@Ian326 Ian326 self-assigned this May 23, 2024
@Ian326 Ian326 changed the title Feat/rf32 expense report deets Feat/Expenses/RF32: Endpoint for expenseReport data by id May 23, 2024
@salgue441 salgue441 merged commit 1c52c6b into develop May 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Zeitgeist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants