Merge pull request #483 from BitGo/COIN-1418-etc-wrw-support

feat(etc): add non-bitgo recovery and unsigned sweep support for etc
BitGo · Aug 30, 2024 · 18a0fac · 18a0fac
2 parents f716375 + 8961b05
commit 18a0fac
Show file tree

Hide file tree

Showing 9 changed files with 7,417 additions and 176 deletions.
diff --git a/ETC.md b/ETC.md
@@ -23,7 +23,7 @@ Create a new file called `broadcastETCTransaction.js`
 and add the following script:
 
 ```js
-const axios = require('axios');
+import axios from 'axios';
 
 // Replace with your API key
 const apiKey = 'your-api-key-here';

diff --git a/electron/main/index.ts b/electron/main/index.ts
@@ -31,6 +31,7 @@ import { Dot, Tdot } from '@bitgo/sdk-coin-dot';
 import { Eos, Teos } from '@bitgo/sdk-coin-eos';
 import { AbstractEthLikeNewCoins, Erc20Token, Eth, Hteth } from '@bitgo/sdk-coin-eth';
 import { Ethw } from '@bitgo/sdk-coin-ethw';
+import { Etc, Tetc } from '@bitgo/sdk-coin-etc';
 import { Ltc } from '@bitgo/sdk-coin-ltc';
 import { Near, TNear } from '@bitgo/sdk-coin-near';
 import { Opeth, Topeth, OpethToken } from '@bitgo/sdk-coin-opeth';
@@ -83,6 +84,8 @@ sdk.register('tbtc', Tbtc.createInstance);
 sdk.register('eth', Eth.createInstance);
 sdk.register('hteth', Hteth.createInstance);
 sdk.register('ethw', Ethw.createInstance);
+sdk.register('etc', Etc.createInstance);
+sdk.register('tetc', Tetc.createInstance);
 sdk.register('eos', Eos.createInstance);
 sdk.register('teos', Teos.createInstance);
 sdk.register('xlm', Xlm.createInstance);

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -29,6 +29,7 @@
     "@bitgo/sdk-coin-doge": "2.0.32",
     "@bitgo/sdk-coin-dot": "4.1.10",
     "@bitgo/sdk-coin-eos": "2.1.25",
+    "@bitgo/sdk-coin-etc": "2.2.0",
     "@bitgo/sdk-coin-eth": "24.2.21",
     "@bitgo/sdk-coin-ethlike": "1.1.13",
     "@bitgo/sdk-coin-ethw": "20.0.32",

diff --git a/scripts/build-icons.js b/scripts/build-icons.js
@@ -13,6 +13,7 @@ const coins = [
   'zec',
   'btg',
   'eth',
+  'etc',
   'trx',
   'bsv',
   'eos',

diff --git a/src/containers/BuildUnsignedSweepCoin/BuildUnsignedSweepCoin.tsx b/src/containers/BuildUnsignedSweepCoin/BuildUnsignedSweepCoin.tsx
@@ -2,7 +2,7 @@ import { useNavigate, useParams } from 'react-router-dom';
 import { CoinsSelectAutocomplete } from '~/components';
 import { useAlertBanner } from '~/contexts';
 import {
-  assert,
+  assert, getEip1559Params,
   getEthLikeRecoveryChainId,
   getTokenChain,
   includePubsFor,
@@ -112,6 +112,8 @@ function Form() {
       );
     case 'eth':
     case 'hteth':
+    case 'etc':
+    case 'tetc':
     case 'arbeth':
     case 'tarbeth':
     case 'opeth':
@@ -135,10 +137,7 @@ function Form() {
                 await updateKeysFromIds(coin, values);
               const recoverData = await window.commands.recover(coin, {
                 ...rest,
-                eip1559: {
-                  maxFeePerGas: toWei(maxFeePerGas),
-                  maxPriorityFeePerGas: toWei(maxPriorityFeePerGas),
-                },
+                eip1559: getEip1559Params(coin, maxFeePerGas, maxPriorityFeePerGas),
                 replayProtectionOptions: {
                   chain: getEthLikeRecoveryChainId(coin, bitGoEnvironment),
                   hardfork: 'london',

diff --git a/src/containers/NonBitGoRecoveryCoin/NonBitGoRecoveryCoin.tsx b/src/containers/NonBitGoRecoveryCoin/NonBitGoRecoveryCoin.tsx
@@ -332,6 +332,8 @@ function Form() {
       );
     case 'eth':
     case 'hteth':
+    case 'etc':
+    case 'tetc':
     case 'arbeth':
     case 'tarbeth':
     case 'opeth':

diff --git a/src/helpers/config.ts b/src/helpers/config.ts
@@ -632,6 +632,7 @@ export const buildUnsignedSweepCoins: Record<
     allCoinMetas.zec,
     allCoinMetas.btg,
     allCoinMetas.eth,
+    allCoinMetas.etc,
     allCoinMetas.ethw,
     allCoinMetas.erc20,
     allCoinMetas.trx,
@@ -661,6 +662,7 @@ export const buildUnsignedSweepCoins: Record<
     allCoinMetas.txrp,
     allCoinMetas.txlm,
     allCoinMetas.hteth,
+    allCoinMetas.tetc,
     allCoinMetas.hterc20,
     allCoinMetas.ttrx,
     allCoinMetas.ttrxToken,
@@ -697,6 +699,7 @@ export const nonBitgoRecoveryCoins: Record<BitgoEnv, readonly CoinMetadata[]> =
       allCoinMetas.zec,
       allCoinMetas.btg,
       allCoinMetas.eth,
+      allCoinMetas.etc,
       allCoinMetas.ethw,
       allCoinMetas.erc20,
       allCoinMetas.trx,
@@ -736,6 +739,7 @@ export const nonBitgoRecoveryCoins: Record<BitgoEnv, readonly CoinMetadata[]> =
       allCoinMetas.txrp,
       allCoinMetas.txlm,
       allCoinMetas.hteth,
+      allCoinMetas.tetc,
       allCoinMetas.hterc20,
       allCoinMetas.ttrx,
       allCoinMetas.ttrxToken,

diff --git a/src/helpers/index.ts b/src/helpers/index.ts
@@ -260,9 +260,13 @@ export function isBscChain(coin: string) {
   return (coin === 'bsc' || coin === 'tbsc')
 }
 
+export function isEtcChain(coin: string) {
+  return (coin === 'etc' ||  coin === 'tetc')
+}
+
 export function getEip1559Params(coin: string, maxFeePerGas: number, maxPriorityFeePerGas: number) {
-  // bsc and tbsc doesn't support EIP-1559
-  if (isBscChain(coin)) {
+  // bsc/tbsc and etc/tetc doesn't support EIP-1559
+  if (isBscChain(coin) || isEtcChain(coin)) {
     return undefined;
   }
   return {
-Original file line number
+Diff line change
@@ Expand Up / @@ -13,6 +13,7 @@ const coins = [ @@
       'zec',
       'btg',
       'eth',
+      'etc',
       'trx',
       'bsv',
       'eos',
@@ Expand Down @@