Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eth-multisig-v4): add oas, coredao config #183

Merged
merged 1 commit into from
Nov 6, 2024
Merged

chore(eth-multisig-v4): add oas, coredao config #183

merged 1 commit into from
Nov 6, 2024

Conversation

adarsh312
Copy link
Contributor

Ticket: WIN-3695

@adarsh312 adarsh312 force-pushed the WIN-3695_forwarder_deployment branch from 829bd3d to 7ef4e83 Compare October 28, 2024 10:36
@adarsh312 adarsh312 force-pushed the WIN-3695_forwarder_deployment branch from 7ef4e83 to b85e6ea Compare October 28, 2024 11:02
@adarsh312 adarsh312 force-pushed the WIN-3695_forwarder_deployment branch from b85e6ea to a658293 Compare October 28, 2024 11:07
@adarsh312 adarsh312 force-pushed the WIN-3695_forwarder_deployment branch from a658293 to f94c8d3 Compare November 5, 2024 06:16
@adarsh312 adarsh312 marked this pull request as ready for review November 5, 2024 09:13
@adarsh312 adarsh312 requested a review from a team as a code owner November 5, 2024 09:13
gianchandania
gianchandania reviewed Nov 5, 2024
View reviewed changes
hardhat.config.ts Outdated
@@ -134,6 +136,14 @@ const config: HardhatUserConfig = {
url: `https://bartio.rpc.berachain.com/`,
accounts: [`${PRIVATE_KEY_FOR_V4_CONTRACT_DEPLOYMENT}`]
},
toas: {
url: `https://rpc.mainnet.oasys.games/`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be mainnet rpc url

hardhat.config.ts Outdated
accounts: [`${PRIVATE_KEY_FOR_V4_CONTRACT_DEPLOYMENT}`]
},
tcoredao: {
url: `https://rpc.ankr.com/core`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also seems to be mainnet rpc url

hardhat.config.ts Outdated
@@ -227,6 +241,22 @@ const config: HardhatUserConfig = {
browserURL: 'https://bartio.beratrail.io'
}
},
{
network: 'oasSandVerse',
chainId: 20197,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this link, the chain id for oasis testnet is 9372. can you confirm which is correct
https://docs.sequence.xyz/solutions/chainlist/non-integrated/oasys-testnet/#rpc-urls

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reference it taken from the docs https://docs.oasys.games/docs/staking/rpc-endpoint/1-1-rpc-endpoint

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, seems like there are multiple testnets

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i switched the the other testnet as that is the widely used one

gianchandania
gianchandania reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@gianchandania gianchandania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please try to use this script in local once to confirm it is working for both networks

@adarsh312 adarsh312 marked this pull request as draft November 5, 2024 14:25
gianchandania
gianchandania reviewed Nov 6, 2024
View reviewed changes
hardhat.config.ts Outdated
@@ -227,6 +241,22 @@ const config: HardhatUserConfig = {
browserURL: 'https://bartio.beratrail.io'
}
},
{
network: 'oasSandVerse',
chainId: 20197,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, seems like there are multiple testnets

hardhat.config.ts Outdated
}
},
{
network: 'coreDao testnet',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here the string should be same as above i.e. coredao

gianchandania
gianchandania reviewed Nov 6, 2024
View reviewed changes
Copy link
Contributor

@gianchandania gianchandania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make sure the explorer API keys are added to github secrets

@adarsh312 adarsh312 force-pushed the WIN-3695_forwarder_deployment branch from 9ead066 to 49498fa Compare November 6, 2024 09:46
@adarsh312 adarsh312 force-pushed the WIN-3695_forwarder_deployment branch from 49498fa to b3949f3 Compare November 6, 2024 09:57
@adarsh312 adarsh312 marked this pull request as ready for review November 6, 2024 10:09
@adarsh312 adarsh312 merged commit 6cdfaec into master Nov 6, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianchandania gianchandania gianchandania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adarsh312 @gianchandania