Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deploy): add script to deploy v1 wallet and forwarder contracts #150

Merged

Conversation

mullapudipruthvik
Copy link
Contributor

Ticket: COIN-114

Copy link

socket-security bot commented May 27, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] None 0 7.69 kB nicolo-ribaudo
npm/@babel/[email protected] None +1 23.9 kB nicolo-ribaudo
npm/[email protected] None 0 7.95 kB cwmma
npm/[email protected] environment, eval, filesystem 0 2.26 MB zloirock
npm/[email protected] None +1 75.8 kB feedic
npm/[email protected] None 0 44.6 kB feedic
npm/[email protected] network 0 56.6 kB feedic
npm/[email protected] environment 0 197 kB jonschlinkert
npm/[email protected] None +1 1.28 MB eslintbot
npm/[email protected] None +1 1.02 MB michaelficarra
npm/[email protected] None +1 156 kB sindresorhus
npm/[email protected] Transitive: filesystem, unsafe +1 9.51 kB sindresorhus
npm/[email protected] None 0 3.23 kB sindresorhus
npm/[email protected] None 0 3.58 kB sindresorhus
npm/[email protected] None 0 34.9 kB isaacs
npm/[email protected] None +2 866 kB hugomrdias
npm/[email protected] None 0 31.1 kB dcousens
npm/[email protected] None 0 39.1 kB typescript-bot
npm/[email protected] None 0 4.01 kB blakeembrey
npm/[email protected] None 0 4.64 kB blakeembrey
npm/[email protected] None 0 10.6 kB jonschlinkert

🚮 Removed packages: npm/@babel/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented May 27, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package Note
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: node -e "try{require('./postinstall')}catch(e){}"

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link
Contributor

@gianchandania gianchandania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change lgtm, how will we deploy old contracts for v1 wallets?

@mullapudipruthvik
Copy link
Contributor Author

we probably have to go back to some commit and create a tag from a branch

@mullapudipruthvik mullapudipruthvik merged commit 58eda4f into master May 27, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants