Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coin 685 test v1 forwarder contract deployment #147

Merged
merged 1 commit into from
May 16, 2024
Merged

Coin 685 test v1 forwarder contract deployment #147

merged 1 commit into from
May 16, 2024

Conversation

gianchandania
Copy link
Contributor

@gianchandania gianchandania commented May 16, 2024 •
edited
Loading

This PR adds private key and a script for v1 forwarder contract deployment.

@socket-security Socket Security
Copy link

socket-security bot commented May 16, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] None +1 23.9 kB nicolo-ribaudo
npm/@babel/[email protected] None +1 200 kB nicolo-ribaudo
npm/@ensdomains/[email protected] Transitive: filesystem, network, unsafe +6 13 MB makoto_inoue
npm/@ensdomains/[email protected] None 0 5.02 MB nickjohnson
npm/@ethereumjs/[email protected] None +1 2.56 MB holgerd77
npm/@ethereumjs/[email protected] None 0 428 kB holgerd77
npm/@ethersproject/[email protected] None 0 495 kB ricmoo
npm/@ethersproject/[email protected] None 0 60.2 kB ricmoo
npm/@ethersproject/[email protected] None 0 82.5 kB ricmoo
npm/@ethersproject/[email protected] None 0 33.1 kB ricmoo
npm/@ethersproject/[email protected] None 0 11.3 kB ricmoo
npm/@ethersproject/[email protected] None +1 99.6 kB ricmoo
npm/@ethersproject/[email protected] None 0 144 kB ricmoo
npm/@ethersproject/[email protected] None 0 80.9 kB ricmoo
npm/@ethersproject/[email protected] None 0 18.7 kB ricmoo
npm/@ethersproject/[email protected] None 0 123 kB ricmoo
npm/@ethersproject/[email protected] None 0 6.09 kB ricmoo
npm/@ethersproject/[email protected] None 0 68.6 kB ricmoo
npm/@ethersproject/[email protected] None 0 44.8 kB ricmoo
npm/@ethersproject/[email protected] None 0 31 kB ricmoo
npm/@ethersproject/[email protected] network +17 2.68 MB ricmoo
npm/@ethersproject/[email protected] None 0 17.3 kB ricmoo
npm/@ethersproject/[email protected] None 0 29.6 kB ricmoo
npm/@ethersproject/[email protected] None 0 21.7 kB ricmoo
npm/@ethersproject/[email protected] None 0 243 kB ricmoo
npm/@ethersproject/[email protected] None 0 119 kB ricmoo
npm/@ethersproject/[email protected] None 0 90 kB ricmoo
npm/@ethersproject/[email protected] network 0 123 kB ricmoo
npm/@truffle/[email protected] None 0 277 kB eggplantzzz
npm/@types/[email protected] None 0 13.9 kB types
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +9 1.76 MB jameshenry
npm/[email protected] None 0 2.43 MB ricmoo
npm/[email protected] None 0 9.98 kB junderw
npm/[email protected] None +6 912 kB chai
npm/[email protected] None 0 4.51 kB substack
npm/[email protected] None +1 75.8 kB feedic
npm/[email protected] network 0 56.6 kB feedic
npm/[email protected] environment, filesystem 0 24.9 kB motdotla
npm/[email protected] None +2 148 kB indutny
npm/[email protected] environment +1 219 kB jonschlinkert
npm/[email protected] None 0 18.2 kB lydell
npm/[email protected] None 0 16.4 kB linusu
npm/[email protected] filesystem, unsafe +2 1.21 MB ljharb
npm/[email protected] filesystem +2 652 kB mysticatea
npm/[email protected] None 0 42.5 kB xjamundx
npm/[email protected] filesystem Transitive: environment, unsafe +29 4.48 MB eslintbot
npm/[email protected] None +1 1.28 MB eslintbot
npm/[email protected] None +1 1.02 MB michaelficarra
npm/[email protected] None 0 51.8 kB gudahtt
npm/[email protected] None +3 1.23 MB alcuadrado
npm/[email protected] None 0 20.3 kB ethworks
npm/[email protected] None +3 585 kB ralxz
npm/[email protected] None 0 225 kB silentcicero
npm/[email protected] None +1 156 kB sindresorhus
npm/[email protected] environment, filesystem 0 32.5 kB isaacs
npm/[email protected] filesystem 0 78.2 kB cgewecke
npm/[email protected] environment, filesystem, network, shell Transitive: unsafe +3 5.02 MB fvictorio
npm/[email protected] None 0 48.9 kB kael
npm/[email protected] Transitive: filesystem, unsafe +1 9.51 kB sindresorhus
npm/[email protected] None 0 50.4 kB isaacs
npm/[email protected] None 0 34.9 kB isaacs
npm/[email protected] None 0 696 kB janther
npm/[email protected] environment, filesystem, unsafe 0 17.7 MB sosukesuzuki
npm/[email protected] environment 0 122 kB matteo.collina
npm/[email protected] filesystem 0 15.5 kB isaacs
npm/[email protected] None 0 62.9 kB ralxz
npm/[email protected] None 0 3.74 kB fvictorio
npm/[email protected] filesystem Transitive: shell +1 288 kB fvictorio
npm/[email protected] filesystem +5 318 kB cgewecke
npm/[email protected] filesystem +1 90.2 kB linusu
npm/[email protected] None +1 6.99 kB sindresorhus
npm/[email protected] None +1 355 kB gajus-table
npm/[email protected] None +1 25.3 kB rkalis
npm/[email protected] environment, filesystem, unsafe +7 2.25 MB cspotcode
npm/[email protected] environment, filesystem +2 172 kB ethereum-ts-bot
npm/[email protected] None 0 64.7 MB typescript-bot
npm/[email protected] None 0 111 kB jashkenas
npm/[email protected] Transitive: filesystem, network, shell +7 438 kB spacesailor
npm/[email protected] None 0 60.9 kB jdevcs
npm/[email protected] Transitive: eval +1 736 kB spacesailor
npm/[email protected] None +1 44.6 kB jdevcs
npm/[email protected] None 0 41.3 kB spacesailor
npm/[email protected] None +1 70.2 kB spacesailor
npm/[email protected] None 0 23.7 kB spacesailor
npm/[email protected] None 0 51.1 kB jdevcs
npm/[email protected] None +2 138 kB spacesailor
npm/[email protected] None +2 125 kB spacesailor
npm/[email protected] None +8 3.39 MB spacesailor
npm/[email protected] None +6 1.19 MB spacesailor
npm/[email protected] None +6 1.19 MB spacesailor
npm/[email protected] None +7 1.42 MB spacesailor
npm/[email protected] None +6 1.18 MB spacesailor
npm/[email protected] None 0 2.29 MB sethkfman
npm/[email protected] None 0 26.2 kB spacesailor
npm/[email protected] None +4 1.25 MB jdevcs
npm/[email protected] None 0 5.72 MB jdevcs
npm/[email protected] environment Transitive: filesystem +1 20.9 kB isaacs
npm/[email protected] network 0 113 kB lpinca
npm/[email protected] environment, filesystem +2 192 kB bcoe

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented May 16, 2024 •
edited
Loading

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: node deprecated.js
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: echo "WARNING: the web3-shh and web3-bzz api will be deprecated in the next version"
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: echo "WARNING: the web3-bzz api will be deprecated in the next version"
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: echo "WARNING: the web3-shh api will be deprecated in the next version"
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: echo "WARNING: the web3-bzz api will be deprecated in the next version"
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: echo "WARNING: the web3-shh api will be deprecated in the next version"
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: echo "WARNING: the web3-shh and web3-bzz api will be deprecated in the next version"
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: echo "WARNING: the web3-shh and web3-bzz api will be deprecated in the next version"

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@gianchandania gianchandania force-pushed the COIN-685-test-v1-forwarder-contract-deployment branch from 2230380 to c5606ef Compare May 16, 2024 13:41
@gianchandania
feat(eth-multisig-v4): add script to deploy v1 forwarder
578b590 
COIN-685

This PR adds private key and a script for v1 forwarder contract deployment.
@gianchandania gianchandania force-pushed the COIN-685-test-v1-forwarder-contract-deployment branch from c5606ef to 578b590 Compare May 16, 2024 13:43
@gianchandania gianchandania marked this pull request as ready for review May 16, 2024 13:44
@gianchandania gianchandania requested a review from a team as a code owner May 16, 2024 13:44
mullapudipruthvik
mullapudipruthvik approved these changes May 16, 2024
View reviewed changes
scripts/deployV1Forwarder.ts
await verifyContract(forwarderContractName, forwarder.address, []);
await verifyContract(forwarderFactoryContractName, forwarderFactory.address, [
forwarder.address
]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure whether etherscan apikey is added

Copy link
Contributor Author

@gianchandania gianchandania May 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added recently

@gianchandania gianchandania merged commit 513403d into master May 16, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mullapudipruthvik mullapudipruthvik mullapudipruthvik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gianchandania @mullapudipruthvik