Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(contracts): upgrade solidity version to 0.8.20 #109

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

gianchandania
Copy link
Contributor

@gianchandania gianchandania commented Oct 4, 2023

This PR upgrades the version of solidity to 0.8.20 for contracts, updates node version, modifies the naming for private keys used for contract deployment.

WIN-666

@socket-security
Copy link

socket-security bot commented Oct 4, 2023

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
solc 0.8.11...0.8.20 filesystem +0/-0 8.9 MB r0qs
@openzeppelin/contracts 4.4.1...4.9.0 None +0/-0 2.05 MB frangio

🚮 Removed packages: [email protected]

Copy link
Contributor

@sachushaji sachushaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, why specifically to 0.8.15?

@gianchandania
Copy link
Contributor Author

Changes LGTM, why specifically to 0.8.15?

I am getting errors related to openzeppelin imports in remix when I am using version higher than this. Will try to solve the error and use version 0.8.20 which is the latest version

@gianchandania gianchandania force-pushed the WIN-666-upgrade-solidity-version branch from 1d6865d to 7a936bd Compare October 5, 2023 10:40
@gianchandania gianchandania force-pushed the WIN-666-upgrade-solidity-version branch from 7a936bd to faa50b7 Compare October 5, 2023 10:41
@gianchandania gianchandania temporarily deployed to dev October 5, 2023 10:41 — with GitHub Actions Inactive
@gianchandania gianchandania force-pushed the WIN-666-upgrade-solidity-version branch from faa50b7 to 5cc0c6f Compare October 5, 2023 10:42
@gianchandania gianchandania temporarily deployed to dev October 5, 2023 10:42 — with GitHub Actions Inactive
@gianchandania gianchandania changed the title chore(contracts): upgrade solidity version to 0.8.15 chore(contracts): upgrade solidity version to 0.8.20 Oct 5, 2023
@gianchandania gianchandania temporarily deployed to dev October 5, 2023 10:51 — with GitHub Actions Inactive
@gianchandania gianchandania temporarily deployed to dev October 5, 2023 10:51 — with GitHub Actions Inactive
@gianchandania gianchandania force-pushed the WIN-666-upgrade-solidity-version branch from fca8f2a to d032ea1 Compare October 5, 2023 10:52
@gianchandania gianchandania temporarily deployed to dev October 5, 2023 10:52 — with GitHub Actions Inactive
@gianchandania gianchandania temporarily deployed to dev October 5, 2023 10:52 — with GitHub Actions Inactive
@gianchandania
Copy link
Contributor Author

@sachushaji I have updated the version to 0.8.20 which is the latest version used in openzeppelin contracts as well

Copy link
Contributor

@sachushaji sachushaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks Akash

@gianchandania gianchandania merged commit bebf6c7 into master Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants