Skip to content

Commit

Permalink
fix violation of check effect interaction pattern
Browse files Browse the repository at this point in the history
  • Loading branch information
gianchandania committed Jan 23, 2024
1 parent da663b9 commit b436905
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions contracts/ForwarderFactory.sol
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ contract ForwarderFactory is CloneFactory {
);

constructor(address _implementationAddress) {
require(_implementationAddress != address(0), 'Invalid implementation address');
implementationAddress = _implementationAddress;
}

Expand All @@ -32,7 +31,7 @@ contract ForwarderFactory is CloneFactory {
bytes32 finalSalt = keccak256(abi.encodePacked(parent, salt));

address payable clone = createClone(implementationAddress, finalSalt);

emit ForwarderCreated(
clone,
parent,
Expand Down

0 comments on commit b436905

Please sign in to comment.