add signer address validation

WIN-1733
BitGo · Jan 23, 2024 · 8111aea · 8111aea
1 parent 165b4be
commit 8111aea
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/contracts/WalletSimple.sol b/contracts/WalletSimple.sol
@@ -80,6 +80,7 @@ contract WalletSimple is IERC721Receiver, ERC1155Receiver {
 
     for (uint8 i = 0; i < allowedSigners.length; i++) {
       require(allowedSigners[i] != address(0), 'Invalid signer');
+      require(!signers[allowedSigners[i]], 'Duplicate signer');
       signers[allowedSigners[i]] = true;
     }
 

diff --git a/test/gas.js b/test/gas.js
@@ -67,7 +67,7 @@ describe(`Wallet Operations Gas Usage`, function () {
       accounts[1],
       accounts[2]
     ]);
-    checkGasUsed(171030, transaction.receipt.gasUsed);
+    checkGasUsed(172810, transaction.receipt.gasUsed);
   });
 
   it('WalletSimple send [ @skip-on-coverage ]', async function () {