Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: Publish the simulators port #1357

Merged
merged 1 commit into from
Jan 9, 2025
Merged

DX: Publish the simulators port #1357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/dockerenv.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,15 @@ dockerdev () {
$RUNTIME rm "$CONTAINER_NAME"
fi

# SYS_PTRACE is needed to run address sanitizer
# * `SYS_PTRACE` is needed to run address sanitizer
# * `-p 15423` publishes the default port the simulator listens on
$RUNTIME run \
--detach \
--interactive --tty \
--name="$CONTAINER_NAME" \
-v "$repo_path":"$MOUNT_DIR" \
--cap-add SYS_PTRACE \
-p 15423:15423 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a comment, it's not obvious what this is for when one does not know

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git blame ;), jk. I'll add a comment

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, force pushed

${CONTAINER_IMAGE}:${CONTAINER_VERSION} bash

if [ "$RUNTIME" = "docker" ] ; then
Expand Down