Cardano: allow serialization using 258-tagged sets #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benma
force-pushed
the
tag-cbor-sets
branch
3 times, most recently
from
f153d36 to
4b93242
Compare
Since the Conway era, the CBOR serialization of inputs and certificates can optionally be tagged with the 258-tag. This will become mandatory in a future hardfork. - https://github.com/IntersectMBO/cardano-ledger/blob/6e2d37cc0f47bd02e89b4ce9f78b59c35c958e96/eras/conway/impl/cddl-files/extra.cddl#L5 - https://www.iana.org/assignments/cbor-tags/cbor-tags.xhtml The protobuf field is named `tag_cbor_sets` to be consistent with other tooling that names it the same way: https://github.com/vacuumlabs/ledgerjs-cardano-shelley/blob/4a59d8818402a1d1d4c9939a6a8f606940f51d55/src/types/public.ts#L1874 This change is needed now as some wallets/tools already use this tag, e.g. delegating to a drep using the https://gov.tools/ DApp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Conway era, the CBOR serialization of inputs and certificates
can optionally be tagged with the 258-tag. This will become mandatory
in a future hardfork.
The protobuf field is named
tag_cbor_setsto be consistent withother tooling that names it the same way: https://github.com/vacuumlabs/ledgerjs-cardano-shelley/blob/4a59d8818402a1d1d4c9939a6a8f606940f51d55/src/types/public.ts#L1874
This change is needed now as some wallets/tools already use this tag,
e.g. delegating to a drep using the https://gov.tools/ DApp.