external: add the optiga-trust-m dependency #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickeZ
reviewed
Nov 27, 2024
|
I've been developing locally on top of this PR for a while now, communicating with the chip, and had no issues. @NickeZ ready for review & merge. |
NickeZ
reviewed
Dec 2, 2024
external/optiga_config.h
Outdated
| */ | ||
| #define OPTIGA_LIB_DEBUG_NULL_CHECK | ||
| /** @brief Maximum number of instance registration */ | ||
| #define OPTIGA_CMD_MAX_REGISTRATIONS (0x06) |
There was a problem hiding this comment.
Could this be 1, does that have any impact on size?
There was a problem hiding this comment.
@NickeZ actually 0x01 fails, 0x02 works. With 0x01, the second one fails:
util = optiga_util_create(OPTIGA_INSTANCE_ID_0, optiga_lib_callback, NULL);
if (NULL == util) {
util_log("couldn't create optiga util");
return false;
}
crypt = optiga_crypt_create(OPTIGA_INSTANCE_ID_0, optiga_lib_callback, NULL);
if (NULL == crypt) {
util_log("couldn't create optiga crypt");
return false;
}
There was a problem hiding this comment.
aha I see, they take one "cmd registration" each.
Needed to interact with the Optiga secure chip. The optiga-trust-m module was forked to the BitBoxSwiss org, along with its own submodule mbedtls, so we are safe against deps disappearing.
|
In the future we could probably reduce the size of the optiga lib by removing support for features as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to interact with the Optiga secure chip.
The optiga-trust-m module was forked to the BitBoxSwiss org, along with its own submodule mbedtls, so we are safe against deps disappearing.