Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update btc deps #1156

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Update btc deps #1156

merged 2 commits into from
Nov 29, 2023

Conversation

benma
Copy link
Collaborator

@benma benma commented Nov 23, 2023

Builds on #1154

The two commits (without Rust toolchain update) yield a binary size reduction of 17524 bytes.

@benma benma requested a review from asi345 November 23, 2023 06:54
Copy link
Collaborator

@asi345 asi345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, I also experienced around 17 KBs of size reduction in the firmware binary.

So they are all in the latest versions and there are no duplicate
dependencies.

This change reduces the binary size by 14740 bytes. ~12kB of this can
be traced back to
rust-bitcoin/rust-miniscript#584.
This reduces the binary size by 2784 bytes.
@benma benma merged commit 7c9170a into BitBoxSwiss:master Nov 29, 2023
1 check passed
@benma benma deleted the update-btc-deps branch November 29, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants