Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Biocparallel batchtoolsparam rmd #219

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from
Open

Biocparallel batchtoolsparam rmd #219

wants to merge 4 commits into from

Conversation

villafup
Copy link

@villafup villafup commented Sep 7, 2022

@Bioconductor/sweave2rmd for review

Original

@mcarlsn
Copy link
Contributor

mcarlsn commented Sep 7, 2022

@villafup I can take a first pass at review and then pass along to @jwokaty. Will follow-up with comments soon.

mcarlsn
mcarlsn suggested changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@mcarlsn mcarlsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@villafup Woo! @this conversion! Just finished a first pass reviewing. Flagging @jwokaty as a second pair of eyes.

vignettes/BiocParallel_BatchtoolsParam.Rmd Outdated Show resolved Hide resolved
vignettes/BiocParallel_BatchtoolsParam.Rmd Outdated Show resolved Hide resolved
vignettes/BiocParallel_BatchtoolsParam.Rmd Outdated Show resolved Hide resolved
vignettes/BiocParallel_BatchtoolsParam.Rmd Outdated Show resolved Hide resolved
vignettes/BiocParallel_BatchtoolsParam.Rmd Outdated Show resolved Hide resolved
vignettes/BiocParallel_BatchtoolsParam.Rmd Show resolved Hide resolved
vignettes/BiocParallel_BatchtoolsParam.Rmd Outdated Show resolved Hide resolved
vignettes/BiocParallel_BatchtoolsParam.Rmd Show resolved Hide resolved
jwokaty
jwokaty requested changes Jan 1, 2023
View reviewed changes
Copy link
Contributor

@jwokaty jwokaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some comments are marked as resolved, but we don't yet have the updated commits. The .Rnw file should also be removed.

vignettes/BiocParallel_BatchtoolsParam.Rmd Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtmorgan mtmorgan mtmorgan left review comments

@mcarlsn mcarlsn mcarlsn requested changes

@jwokaty jwokaty jwokaty requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@villafup @mcarlsn @mtmorgan @jwokaty