Skip to content

Commit

Permalink
add additional deprecation functions to the list
Browse files Browse the repository at this point in the history
  • Loading branch information
LiNk-NY committed Nov 1, 2024
1 parent cb9fcb7 commit 604e56c
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
7 changes: 6 additions & 1 deletion R/checkRcoding.R
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,12 @@ checkCodingPractice <- function(.BiocPackage, parsedCode)

# .Deprecated / .Defunct usage should be updated after every release
msg_depr <- findSymbolsInRFiles(
.BiocPackage, c(".Deprecated", ".Defunct"), "SYMBOL_FUNCTION_CALL"
.BiocPackage,
c(
".Deprecated", ".Defunct", "lifeCycle",
"deprecate_warn", "deprecate_stop"
),
"SYMBOL_FUNCTION_CALL"
)
if (length(msg_depr)) {
handleWarning(
Expand Down
8 changes: 4 additions & 4 deletions vignettes/BiocCheck.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -413,10 +413,10 @@ directory.
('=') for clarity in the code and legibility. Any use of the `=` will be
flagged with a `NOTE`.

* New submissions should not use any `.Deprecated` or `.Defunct` function calls
(`WARNING`). Existing packages should evolve `.Deprecated` and `.Defunct`
functions after a Bioconductor release according to the
[package guidelines][6].
* New submissions should not use any `.Deprecated`, `.Defunct`, `lifeCycle`,
`deprecate_warn`, or `deprecate_stop` function calls (`WARNING`). Existing
packages should evolve these functions after a Bioconductor release according
to the [package guidelines][6].

[6]: https://contributions.bioconductor.org/deprecation.html

Expand Down

0 comments on commit 604e56c

Please sign in to comment.