Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use config of bulk service manager for its operations #172

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Prev Previous commit
Next Next commit
Make fields final
  • Loading branch information
markusheiden committed Mar 1, 2024
commit 2be2c83b47272a2da8fe3725bcd5872e93e74873
15 changes: 4 additions & 11 deletions src/main/java/com/microsoft/bingads/v13/bulk/BulkOperation.java
Original file line number Diff line number Diff line change
@@ -29,12 +29,12 @@ public abstract class BulkOperation<TStatus> {
/**
* The request identifier corresponding to the bulk upload or download, depending on the derived type.
*/
private String requestId;
private final String requestId;

/**
* The identifier of the log entry that contains the details of the upload or download request.
*/
private String trackingId;
private final String trackingId;

private final ServiceClient<IBulkService> serviceClient;

@@ -162,14 +162,6 @@ BulkOperationStatusProvider<TStatus> getStatusProvider() {
return statusProvider;
}

void setRequestId(String requestId) {
this.requestId = requestId;
}

void setTrackingId(String trackingId) {
this.trackingId = trackingId;
}

HttpFileService getHttpFileService() {
return httpFileService;
}
@@ -226,7 +218,8 @@ public Future<File> downloadResultFileAsync(File localResultDirectoryName, Strin

abstract RuntimeException getOperationCouldNotBeCompletedException(List<OperationError> errors, TStatus status);

private Future<File> downloadResultFileAsyncImpl(final File localResultDirectoryName, final String localResultFileName, final boolean decompress, final boolean overwrite, AsyncCallback<File> callback) throws IOException, URISyntaxException {
private Future<File> downloadResultFileAsyncImpl(final File
localResultDirectoryName, final String localResultFileName, final boolean decompress, final boolean overwrite, AsyncCallback<File> callback) throws IOException, URISyntaxException {
final ResultFuture<File> resultFuture = new ResultFuture<File>(callback);

if (finalStatus == null) {