Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save generation images (step, solo) #717

Closed
wants to merge 8 commits into from
Closed

Conversation

MarcusNyne
Copy link

These enhancements to ADetailer offer additional opportunities for saving generation images during inpaint processing.

Save incremental step images

A global setting has been added called "Save incremental step images". When enabled, images generated between inpainting steps will be saved. The file will be saved after inpainting when the image is not the final step, and when the image is not from a solo generation (below).

Save solo images

A setting has been added to ADetailer tabs called "Solo generation". When enabled, this inpainting step will not be applied to the final image. Instead, a new image will be generated and saved based on the original image. Solo images will only ever be produced with one inpainting step applied. The image generation parameters for this image will reflect the one adetailer step.

- Added global setting "Save incremental step images"
- When this setting is set, and there are multiple models, images between inpainting applications will be saved.  This excludes "solo" generations
- Added a model-level setting "Solo generation".  When checked, this model will not be added to the final image.  Instead, a new "solo" image will be generated from the original image with only this model applied.
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 17, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 17, 2024
Copy link

@MarcusNyne
Copy link
Author

@Bing-su, thank you for this wonderful extension! I made some enhancements that I hope you will like. Please let me know if you have any questions or feedback.

Thank you!

@Bing-su
Copy link
Owner

Bing-su commented Sep 18, 2024

Regardless of the usefulness of the feature, I don't want to maintain this mess of code. My code is already messy enough.

@MarcusNyne
Copy link
Author

@Bing-su , would you be interested in a subset of these features to reduce the changes to your code? Is there one of the two features which you think is useful enough? I could make changes for just one feature to keep it simple.

The changes were more than I would have liked because I had to make Ruff happy.. my original changes looked cleaner.

@Bing-su
Copy link
Owner

Bing-su commented Sep 18, 2024

I'm sorry. If you want this feature, I'd recommend using a forked repository.

@Bing-su Bing-su closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants