Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cannot read property 'chart' of undefined error #82

Merged
merged 1 commit into from
Nov 3, 2017
Merged

Fix Cannot read property 'chart' of undefined error #82

merged 1 commit into from
Nov 3, 2017

Conversation

mattlewis92
Copy link
Contributor

As pChart.reflow throws an exception, the duration never gets decremented so the interval runs forever. This makes sure the duration is always decremented before trying to get the chart to reflow.

Closes #75

@mattlewis92 mattlewis92 mentioned this pull request Nov 3, 2017
Merged
@Bigous Bigous merged commit 85fb91e into Bigous:master Nov 3, 2017
@mattlewis92 mattlewis92 deleted the patch-2 branch November 3, 2017 11:40
Bigous added a commit that referenced this pull request Nov 3, 2017
@Bigous
fix(reflow): In some cases, reflow was called after the component was…
081b97a 
… deleted.

To provide some "beaultiful" resize UX, reflow is called each 50ms when resizing the component. When
there is a resize and and a destroy, the setInterval could call reflow on an invalid object.

Closes #75, #82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattlewis92 @Bigous