Fix crash when publishing error message to commandStatusTopic

BigThunderSR · Dec 25, 2023 · 7c29cdb · 7c29cdb
1 parent 7c3a622
commit 7c29cdb
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -30,6 +30,7 @@
   "homepage": "https://github.com/BigThunderSR/onstar2mqtt#readme",
   "dependencies": {
     "async-mqtt": "^2.6.3",
+    "circular-json": "^0.5.9",
     "convert-units": "^2.3.4",
     "dotenv": "^16.3.1",
     "lodash": "^4.17.21",

diff --git a/src/index.js b/src/index.js
@@ -7,6 +7,8 @@ const {Diagnostic} = require('./diagnostic');
 const MQTT = require('./mqtt');
 const Commands = require('./commands');
 const logger = require('./logger');
+const CircularJSON = require('circular-json');
+
 
 
 const onstarConfig = {
@@ -111,7 +113,7 @@ const configureMQTT = async (commands, client, mqttHA) => {
             })
             .catch((err)=> {logger.error('Command error', {command, err})            
             logger.info(commandStatusTopic);
-            client.publish(commandStatusTopic, JSON.stringify({"Command": err}), {retain: true})});
+            client.publish(commandStatusTopic, CircularJSON.stringify({"Command": err}), {retain: true})});
     });
     const topic = mqttHA.getCommandTopic();
     logger.info('Subscribed to command topic', {topic});