Enh/clean assets #2637
Merged
Enh/clean assets #2637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bob0005! You need to be added as a user to interact with me. Please ask @ponderingdemocritus to add you on the settings page. You are receiving this comment because I am set to review all PRs. That is configurable here. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
WalkthroughThis pull request involves a comprehensive reorganization of image and resource paths across multiple client applications. The changes primarily focus on restructuring asset directories, updating image source paths, and modifying configuration files to reflect the new directory structure. Key modifications include moving images to more organized subdirectories like Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (16)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
client/apps/landing/src/components/ui/elements/ResourceIcon.tsx (1)
Line range hint
32-65: Update image paths in Components object to match new directory structure.The image paths in the Components object should be updated to match the new directory structure being implemented across the project.
Apply this pattern to update the paths:
const Components: { [key: string]: Resource } = Object.freeze({ Adamantine: { - component: <img src={`/images/resources/20.png`} />, + component: <img src={`/images/icons/resources/20.png`} />, name: "Adamantine", }, // Update remaining paths similarly...
🧹 Nitpick comments (2)
client/apps/game/hex/index.html (1)
7-12: Consider performance impact of asset reorganization.The reorganization of assets into subdirectories might affect load times. Consider implementing a loading strategy:
- Implement lazy loading for non-critical resources
- Use image sprites for frequently used icons
- Consider implementing a CDN for better asset delivery
client/apps/game/index.html (1)
67-89: Standardize naming convention for building thumbnails.The building thumbnail filenames use inconsistent naming conventions:
- camelCase:
castleZero.png- kebab-case:
fragment-mine.png- lowercase:
house.pngConsider standardizing to kebab-case for better consistency with web conventions.
Example changes:
- <link rel="prefetch" href="/images/buildings/thumb/castleZero.png" /> + <link rel="prefetch" href="/images/buildings/thumb/castle-zero.png" />
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (270)
client/apps/balancing/public/vite.svgis excluded by!**/*.svgclient/apps/balancing/src/assets/react.svgis excluded by!**/*.svgclient/apps/game-docs/docs/public/buildings/wonder.pngis excluded by!**/*.pngclient/apps/game-docs/docs/public/resources/249.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/archery.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/barracks.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/farm.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/fishing_village.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/forge.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/lumber_mill.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/market.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/mine.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/stable.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/storehouse.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/workers_hut.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/archer-tower.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/army.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/castle.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/military.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/realm.pngis excluded by!**/*.pngclient/apps/game/public/images/covers/03.pngis excluded by!**/*.pngclient/apps/game/public/images/icons/250.pngis excluded by!**/*.pngclient/apps/game/public/images/icons/251.pngis excluded by!**/*.pngclient/apps/game/public/images/icons/252.pngis excluded by!**/*.pngclient/apps/game/public/images/icons/troop.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/1.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/10.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/11.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/12.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/13.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/14.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/15.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/16.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/17.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/18.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/19.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/2.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/20.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/21.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/22.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/254.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/255.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/29.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/3.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/4.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/5.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/6.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/7.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/8.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/9.pngis excluded by!**/*.pngclient/apps/game/public/images/squire.pngis excluded by!**/*.pngclient/apps/game/public/sound/buildings/storehouse.wavis excluded by!**/*.wavclient/apps/game/public/sound/ui/Click_8.wavis excluded by!**/*.wavclient/apps/game/public/sound/ui/ESM_GB_fx_foley_one_shot_firebrst_crackle_crunchy_light_foley_fire_01_natural_organic_material.wavis excluded by!**/*.wavclient/apps/game/public/sound/ui/click.mp3is excluded by!**/*.mp3client/apps/game/public/sound/ui/harvest.mp3is excluded by!**/*.mp3client/apps/game/public/sound/ui/harvest_fish.mp3is excluded by!**/*.mp3client/apps/game/public/sound/ui/harvest_wheat.mp3is excluded by!**/*.mp3client/apps/game/public/sound/ui/katana.mp3is excluded by!**/*.mp3client/apps/game/public/sound/ui/mint.mp3is excluded by!**/*.mp3client/apps/game/public/sound/ui/sidebar_in.mp3is excluded by!**/*.mp3client/apps/game/public/sound/ui/sidebar_out.mp3is excluded by!**/*.mp3client/apps/landing/public/eternum_new_logo.svgis excluded by!**/*.svgclient/apps/landing/public/images/Castle.pngis excluded by!**/*.pngclient/apps/landing/public/images/Dark Plains.pngis excluded by!**/*.pngclient/apps/landing/public/images/argent-x.svgis excluded by!**/*.svgclient/apps/landing/public/images/avatars/Armor.pngis excluded by!**/*.pngclient/apps/landing/public/images/avatars/Axe.pngis excluded by!**/*.pngclient/apps/landing/public/images/avatars/Battle-axe.pngis excluded by!**/*.pngclient/apps/landing/public/images/avatars/Blade.pngis excluded by!**/*.pngclient/apps/landing/public/images/avatars/Dual-Wield.pngis excluded by!**/*.pngclient/apps/landing/public/images/avatars/Handaxe.pngis excluded by!**/*.pngclient/apps/landing/public/images/avatars/Hidden.pngis excluded by!**/*.pngclient/apps/landing/public/images/avatars/Hilt.pngis excluded by!**/*.pngclient/apps/landing/public/images/avatars/Javelin.pngis excluded by!**/*.pngclient/apps/landing/public/images/avatars/Spear.pngis excluded by!**/*.pngclient/apps/landing/public/images/avatars/Sword.pngis excluded by!**/*.pngclient/apps/landing/public/images/avatars/WrappedAxe.pngis excluded by!**/*.pngclient/apps/landing/public/images/avatars/mercenary.pngis excluded by!**/*.pngclient/apps/landing/public/images/braavos.svgis excluded by!**/*.svgclient/apps/landing/public/images/buildings/construction/archery.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/construction/barracks.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/construction/dragonhide.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/construction/farm.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/construction/fishing_village.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/construction/forge.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/construction/lumber_mill.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/construction/market.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/construction/mine.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/construction/stable.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/construction/storehouse.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/construction/workers_hut.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/archer-tower.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/army.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/banks.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/castle.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/crane.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/discord.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/fragment-mine.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/guilds.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/house.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/hyperstructure.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/leaderboard.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/military.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/question-wood.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/question.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/realm.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/resources.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/scale.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/settings.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/silo.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/squire.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/sword.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/timeglass.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/trade.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/trophy.pngis excluded by!**/*.pngclient/apps/landing/public/images/buildings/thumb/world-map.pngis excluded by!**/*.pngclient/apps/landing/public/images/cover.pngis excluded by!**/*.pngclient/apps/landing/public/images/eternum-logo.svgis excluded by!**/*.svgclient/apps/landing/public/images/eternum-logo_animated.pngis excluded by!**/*.pngclient/apps/landing/public/images/eternum_logo.pngis excluded by!**/*.pngclient/apps/landing/public/images/eternum_with_snake.pngis excluded by!**/*.pngclient/apps/landing/public/images/eternumloader.pngis excluded by!**/*.pngclient/apps/landing/public/images/hidden-castle.pngis excluded by!**/*.pngclient/apps/landing/public/images/icons/250.pngis excluded by!**/*.pngclient/apps/landing/public/images/icons/251.pngis excluded by!**/*.pngclient/apps/landing/public/images/icons/252.pngis excluded by!**/*.pngclient/apps/landing/public/images/icons/attack.pngis excluded by!**/*.pngclient/apps/landing/public/images/icons/claim.pngis excluded by!**/*.pngclient/apps/landing/public/images/icons/leave-battle.pngis excluded by!**/*.pngclient/apps/landing/public/images/icons/raid.pngis excluded by!**/*.pngclient/apps/landing/public/images/icons/troop.pngis excluded by!**/*.pngclient/apps/landing/public/images/jungle-clouds.pngis excluded by!**/*.pngclient/apps/landing/public/images/oroborus.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/1.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/10.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/11.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/12.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/13.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/14.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/15.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/16.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/17.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/18.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/19.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/2.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/20.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/21.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/22.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/254.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/255.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/29.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/3.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/4.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/5.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/6.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/7.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/8.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/9.pngis excluded by!**/*.pngclient/apps/landing/public/images/resources/coin.pngis excluded by!**/*.pngclient/apps/landing/public/images/squire.pngis excluded by!**/*.pngclient/apps/landing/public/og-image.pngis excluded by!**/*.pngclient/common/public/draco/draco_decoder.wasmis excluded by!**/*.wasmclient/common/public/draco/gltf/draco_decoder.wasmis excluded by!**/*.wasmclient/common/public/gifs/bridge-in.gifis excluded by!**/*.gifclient/common/public/gifs/bridge-out-final.gifis excluded by!**/*.gifclient/common/public/gifs/bridge-out-start.gifis excluded by!**/*.gifclient/common/public/gifs/final-bridge-in.gifis excluded by!**/*.gifclient/common/public/images/avatars/01.pngis excluded by!**/*.pngclient/common/public/images/avatars/02.pngis excluded by!**/*.pngclient/common/public/images/avatars/03.pngis excluded by!**/*.pngclient/common/public/images/avatars/04.pngis excluded by!**/*.pngclient/common/public/images/avatars/05.pngis excluded by!**/*.pngclient/common/public/images/avatars/06.pngis excluded by!**/*.pngclient/common/public/images/avatars/07.pngis excluded by!**/*.pngclient/common/public/images/avatars/08.pngis excluded by!**/*.pngclient/common/public/images/avatars/09.pngis excluded by!**/*.pngclient/common/public/images/avatars/10.pngis excluded by!**/*.pngclient/common/public/images/avatars/11.pngis excluded by!**/*.pngclient/common/public/images/avatars/12.pngis excluded by!**/*.pngclient/common/public/images/avatars/DEPRECATED/01.pngis excluded by!**/*.pngclient/common/public/images/avatars/DEPRECATED/02.pngis excluded by!**/*.pngclient/common/public/images/avatars/DEPRECATED/03.pngis excluded by!**/*.pngclient/common/public/images/avatars/DEPRECATED/04.pngis excluded by!**/*.pngclient/common/public/images/avatars/DEPRECATED/05.pngis excluded by!**/*.pngclient/common/public/images/avatars/DEPRECATED/06.pngis excluded by!**/*.pngclient/common/public/images/avatars/DEPRECATED/07.pngis excluded by!**/*.pngclient/common/public/images/avatars/DEPRECATED/08.pngis excluded by!**/*.pngclient/common/public/images/avatars/DEPRECATED/09.pngis excluded by!**/*.pngclient/common/public/images/avatars/DEPRECATED/10.pngis excluded by!**/*.pngclient/common/public/images/avatars/mercenary.pngis excluded by!**/*.pngclient/common/public/images/buildings/construction/archery.pngis excluded by!**/*.pngclient/common/public/images/buildings/construction/bank.pngis excluded by!**/*.pngclient/common/public/images/buildings/construction/barracks.pngis excluded by!**/*.pngclient/common/public/images/buildings/construction/dragonhide.pngis excluded by!**/*.pngclient/common/public/images/buildings/construction/farm.pngis excluded by!**/*.pngclient/common/public/images/buildings/construction/fishing_village.pngis excluded by!**/*.pngclient/common/public/images/buildings/construction/forge.pngis excluded by!**/*.pngclient/common/public/images/buildings/construction/fragment_mine.pngis excluded by!**/*.pngclient/common/public/images/buildings/construction/hyperstructure.pngis excluded by!**/*.pngclient/common/public/images/buildings/construction/lumber_mill.pngis excluded by!**/*.pngclient/common/public/images/buildings/construction/market.pngis excluded by!**/*.pngclient/common/public/images/buildings/construction/mine.pngis excluded by!**/*.pngclient/common/public/images/buildings/construction/stable.pngis excluded by!**/*.pngclient/common/public/images/buildings/construction/storehouse.pngis excluded by!**/*.pngclient/common/public/images/buildings/construction/workers_hut.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/banks.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/castleOne.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/castleThree.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/castleTwo.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/castleZero.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/crane.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/discord.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/fragment-mine.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/guilds.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/house.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/hyperstructure.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/leaderboard.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/question-wood.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/question.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/resources.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/rewards.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/scale.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/settings.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/silo.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/squire.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/sword.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/timeglass.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/trade.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/trophy.pngis excluded by!**/*.pngclient/common/public/images/buildings/thumb/world-map.pngis excluded by!**/*.pngclient/common/public/images/covers/01.pngis excluded by!**/*.pngclient/common/public/images/covers/02.pngis excluded by!**/*.pngclient/common/public/images/covers/03.pngis excluded by!**/*.pngclient/common/public/images/covers/04.pngis excluded by!**/*.pngclient/common/public/images/covers/05.pngis excluded by!**/*.pngclient/common/public/images/covers/06.pngis excluded by!**/*.pngclient/common/public/images/covers/07.pngis excluded by!**/*.pngclient/common/public/images/covers/empire-og-image.jpgis excluded by!**/*.jpgclient/common/public/images/covers/eternum-documentation.pngis excluded by!**/*.pngclient/common/public/images/covers/game-cover.pngis excluded by!**/*.pngclient/common/public/images/covers/og-image-docs.pngis excluded by!**/*.pngclient/common/public/images/covers/og-image.pngis excluded by!**/*.pngclient/common/public/images/game-apple-touch-icon-180x180.pngis excluded by!**/*.pngclient/common/public/images/game-favicon.icois excluded by!**/*.icoclient/common/public/images/game-maskable-icon-512x512.pngis excluded by!**/*.pngclient/common/public/images/game-pwa-192x192.pngis excluded by!**/*.pngclient/common/public/images/game-pwa-512x512.pngis excluded by!**/*.pngclient/common/public/images/game-pwa-64x64.pngis excluded by!**/*.pngclient/common/public/images/hex-bg.pngis excluded by!**/*.pngclient/common/public/images/icons/250.pngis excluded by!**/*.pngclient/common/public/images/icons/251.pngis excluded by!**/*.pngclient/common/public/images/icons/252.pngis excluded by!**/*.pngclient/common/public/images/icons/attack.pngis excluded by!**/*.pngclient/common/public/images/icons/claim.pngis excluded by!**/*.pngclient/common/public/images/icons/cursor-cross.pngis excluded by!**/*.pngclient/common/public/images/icons/cursor.pngis excluded by!**/*.pngclient/common/public/images/icons/grab.pngis excluded by!**/*.pngclient/common/public/images/icons/leave-battle.pngis excluded by!**/*.pngclient/common/public/images/icons/raid.pngis excluded by!**/*.pngclient/common/public/images/landing-apple-touch-icon-180x180.pngis excluded by!**/*.pngclient/common/public/images/landing-favicon.icois excluded by!**/*.icoclient/common/public/images/landing-maskable-icon-512x512.pngis excluded by!**/*.pngclient/common/public/images/landing-pwa-192x192.pngis excluded by!**/*.pngclient/common/public/images/landing-pwa-512x512.pngis excluded by!**/*.pngclient/common/public/images/landing-pwa-64x64.pngis excluded by!**/*.pngclient/common/public/images/logos/BuiltDojo.svgis excluded by!**/*.svgclient/common/public/images/logos/Cartridge.pngis excluded by!**/*.pngclient/common/public/images/logos/Dojo.svgis excluded by!**/*.svgclient/common/public/images/logos/Eternum-Mark-Black.pngis excluded by!**/*.png
📒 Files selected for processing (23)
.gitignore(1 hunks)client/apps/game-docs/docs/pages/mechanics/realm/wonders.mdx(1 hunks)client/apps/game/hex/index.html(1 hunks)client/apps/game/index.html(3 hunks)client/apps/game/map/index.html(1 hunks)client/apps/game/src/hooks/useUISound.tsx(0 hunks)client/apps/game/src/ui/components/WorldLoading.tsx(1 hunks)client/apps/game/src/ui/components/cityview/realm/SettleRealmComponent.tsx(1 hunks)client/apps/game/src/ui/elements/LoadingAnimation.tsx(1 hunks)client/apps/game/src/ui/layouts/Onboarding.tsx(1 hunks)client/apps/game/src/ui/modules/LoadingScreen.tsx(1 hunks)client/apps/game/src/ui/modules/loading-oroborus.tsx(1 hunks)client/apps/game/src/ui/modules/onboarding/Steps.tsx(1 hunks)client/apps/game/tailwind.config.js(1 hunks)client/apps/game/vite.config.ts(1 hunks)client/apps/landing/public/resource_addresses/local/resource_addresses.json(0 hunks)client/apps/landing/public/resource_addresses/mainnet/resource_addresses.json(0 hunks)client/apps/landing/public/resource_addresses/sepolia/resource_addresses.json(0 hunks)client/apps/landing/src/components/ui/elements/CountdownTimer.tsx(1 hunks)client/apps/landing/src/components/ui/elements/ResourceIcon.tsx(1 hunks)client/apps/landing/src/main.tsx(1 hunks)client/apps/landing/src/routes/index.lazy.tsx(7 hunks)client/apps/landing/vite.config.ts(1 hunks)
💤 Files with no reviewable changes (4)
- client/apps/game/src/hooks/useUISound.tsx
- client/apps/landing/public/resource_addresses/local/resource_addresses.json
- client/apps/landing/public/resource_addresses/mainnet/resource_addresses.json
- client/apps/landing/public/resource_addresses/sepolia/resource_addresses.json
✅ Files skipped from review due to trivial changes (12)
- client/apps/game/src/ui/elements/LoadingAnimation.tsx
- client/apps/game/src/ui/modules/loading-oroborus.tsx
- client/apps/game/src/ui/components/WorldLoading.tsx
- client/apps/game-docs/docs/pages/mechanics/realm/wonders.mdx
- client/apps/game/src/ui/modules/LoadingScreen.tsx
- client/apps/landing/src/components/ui/elements/CountdownTimer.tsx
- client/apps/game/src/ui/layouts/Onboarding.tsx
- client/apps/landing/src/main.tsx
- client/apps/game/src/ui/modules/onboarding/Steps.tsx
- client/apps/game/src/ui/components/cityview/realm/SettleRealmComponent.tsx
- .gitignore
- client/apps/landing/src/routes/index.lazy.tsx
⏰ Context from checks skipped due to timeout of 90000ms (17)
- GitHub Check: test-various (test_ownership_systems)
- GitHub Check: test-various (transport_test)
- GitHub Check: test-various (guild_test)
- GitHub Check: test-various (realm_test)
- GitHub Check: test-various (trade_test)
- GitHub Check: test-various (resource_bridge_test)
- GitHub Check: test-various (map_test)
- GitHub Check: test-various (bank_test)
- GitHub Check: test-various (hyperstructure_test)
- GitHub Check: test-various (config_test)
- GitHub Check: test-various (resources_test)
- GitHub Check: test-various (position_test)
- GitHub Check: test-various (owner_test)
- GitHub Check: test-various (combat_test)
- GitHub Check: test-various (season_test)
- GitHub Check: Run pr agent on every pull request, respond to user comments
- GitHub Check: clippy
🔇 Additional comments (7)
client/apps/landing/vite.config.ts (1)
30-30: LGTM! Good practice to centralize static assets.Centralizing public assets in a common directory is a good practice for sharing resources between apps.
Let's verify the common public directory exists:
✅ Verification successful
✅ Verified: Common public directory is properly configured and used
The configuration is correct and safe:
- The common/public directory exists with proper asset structure
- No hardcoded public paths found in the codebase
- Components use proper asset referencing patterns
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the common public directory exists and contains assets if [ -d "client/common/public" ]; then echo "Directory exists. Listing contents:" ls -la client/common/public else echo "Warning: Directory client/common/public does not exist" fi # Check if any image files reference the old paths rg -g '*.{tsx,jsx,ts,js,html}' -i 'src=["\']/(?!images/).*\.(png|jpg|jpeg|gif|svg|webp)' client/apps/landing/Length of output: 1067
Script:
#!/bin/bash # Check for asset references in landing app rg -g '*.{tsx,jsx,ts,js,html}' -i 'src=["\']/' client/apps/landing/ # Check if there are any references to old public directory fd -t f -e tsx -e jsx -e ts -e js -e html . client/apps/landing --exec grep -l "public/"Length of output: 116
Script:
#!/bin/bash # Check for asset references in landing app source files cd client/apps/landing find . -type f \( -name "*.tsx" -o -name "*.jsx" -o -name "*.ts" -o -name "*.js" -o -name "*.html" \) -exec grep -l "src=" {} \; # Check for public directory references find . -type f \( -name "*.tsx" -o -name "*.jsx" -o -name "*.ts" -o -name "*.js" -o -name "*.html" \) -exec grep -l "public/" {} \;Length of output: 722
client/apps/game/vite.config.ts (1)
101-101: LGTM! Consistent with landing app configuration.The shared public directory configuration aligns well with the existing PWA manifest image paths.
Let's verify the PWA assets exist in the new structure:
client/apps/landing/src/components/ui/elements/ResourceIcon.tsx (1)
1-7: LGTM! SVG imports updated correctly.The change to use
?reactquery parameter for SVG imports aligns with Vite's recommended approach for handling SVGs as React components.client/apps/game/tailwind.config.js (1)
110-110: LGTM! Asset paths updated consistently.The backgroundImage and cursor configurations have been updated to use the new directory structure, maintaining consistency with the project-wide asset reorganization.
Also applies to: 118-122
client/apps/game/hex/index.html (1)
5-12: Verify removal of prefetched resources.Several prefetch links (troop.png, archer-tower.png, army.png, military.png, realm.png) have been removed. Please confirm that these resources are no longer needed or are being loaded through a different mechanism.
Run this script to check for usage of the removed resources:
✅ Verification successful
Prefetch removal verified - assets reorganized
The removed prefetch resources have been reorganized:
- Military assets consolidated into building-specific images (e.g., archery.png)
- Combat-related assets moved to thumb directory (sword.png, squire.png)
- Assets properly organized in buildings/construction/ and buildings/thumb/ directories
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if removed resources are still referenced in the codebase # Search for references to removed resources echo "Checking for references to removed resources..." rg -l "troop\.png|archer-tower\.png|army\.png|military\.png|realm\.png"Length of output: 178
Script:
#!/bin/bash # Check for existence of files and similar references # Search for files with similar names in any format echo "Searching for similar image files..." fd -e png -e svg -e jpg -e jpeg "troop|archer|tower|army|military|realm" images/ # Search for references without file extensions echo -e "\nSearching for references without extensions..." rg -l "troop|archer.?tower|army|military|realm" --type html --type js --type ts --type jsx --type tsx # Check specific images directory structure echo -e "\nListing images directory structure..." fd . images/ -t dLength of output: 707
Script:
#!/bin/bash # Find image assets location and references # Find potential asset directories echo "Searching for asset directories..." fd -t d "images|assets|public|static|dist" # Search for any reference to these resources in all files echo -e "\nSearching for resource references..." rg -l "/images/|troop|archer|tower|army|military|realm" --type html --type js --type ts # List files in the found directories echo -e "\nListing files in potential asset directories..." for dir in $(fd -t d "images|assets|public|static|dist"); do echo "Contents of $dir:" ls -la "$dir" 2>/dev/null doneLength of output: 14942
Script:
#!/bin/bash # Check contents of relevant image subdirectories echo "Checking buildings directory..." ls -la client/common/public/images/buildings/ echo -e "\nChecking icons directory..." ls -la client/common/public/images/icons/ echo -e "\nChecking resources directory..." ls -la client/common/public/images/resources/Length of output: 3018
Script:
#!/bin/bash # Check building-related directories and search for possible renamed files echo "Checking building construction directory..." ls -la client/common/public/images/buildings/construction/ echo -e "\nChecking building thumbnails..." ls -la client/common/public/images/buildings/thumb/ # Let's also check if there are any SVG alternatives echo -e "\nSearching for SVG files with similar names..." fd -e svg "troop|archer|tower|army|military|realm" client/common/public/Length of output: 3302
client/apps/game/map/index.html (1)
5-12: Duplicate changes detected.The changes in this file mirror those in
client/apps/game/hex/index.html. The same considerations about removed prefetch links and performance impact apply here.client/apps/game/index.html (1)
5-11: Verify resource existence in new locations.The reorganization of resources into subdirectories looks good, but let's ensure all resources exist in their new locations.
✅ Verification successful
All resources exist in their expected locations
The paths in the HTML file correctly map to existing resources under
client/common/public/images/, with proper organization of icons, logos, and root assets.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify existence of global resources in new locations # Note: Using fd to find files as paths are relative to repo root echo "Checking global resources..." fd -t f -e png -e svg "eternum-animated.png|map.svg|cursor.png|grab.png|argent-x.svg|cursor-cross.png|cover.png" images/Length of output: 284
Script:
#!/bin/bash # First, let's find where images directories might be echo "Looking for 'images' directories..." fd -t d "^images$" echo -e "\nLooking for the specific files anywhere..." fd -t f "eternum-animated.png|map.svg|cursor.png|grab.png|argent-x.svg|cursor-cross.png"Length of output: 706
|
Failed to generate code suggestions for PR |
| @@ -5,7 +5,7 @@ description: The Wonders of Realms Eternum | |||
|
|
|||
| # The Wonders | |||
|
|
|||
| <img src="/buildings/wonder.png" alt="Wonder" width="200" className="float-left " /> | |||
| <img src="/buildings/dragonhide.png" alt="Wonder" width="200" className="float-left " /> | |||
There was a problem hiding this comment.
It is the 3d model of the dragonhide building. We used it as model for wonders as tmp for s0.
aymericdelab
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
Asset Management
Configuration
Sound
Cleanup
.gitignoreto handle.DS_StorefilesDocumentation