-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main #2595
Merge main #2595
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good and implement the new LORDS_AND_DONKEY_RESOURCE_TRACKER appropriately. Consider adding documentation comments above the resource tracker constants to explain what they represent and how they relate to each other. The implementation follows existing patterns and handles the new tracker type correctly.
Thanks for using MentatBot. Give comments a 👍 or 👎 to help me improve!
@@ -69,7 +70,9 @@ const usePlayerArrivals = () => { | |||
// Check if entity has special resource types that don't need weight check | |||
const hasSpecialResources = | |||
ownedResourceTracker?.resource_types === DONKEY_RESOURCE_TRACKER || | |||
ownedResourceTracker?.resource_types === LORDS_RESOURCE_TRACKER; | |||
ownedResourceTracker?.resource_types === LORDS_RESOURCE_TRACKER || | |||
ownedResourceTracker?.resource_types === LORDS_AND_DONKEY_RESOURCE_TRACKER; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this extra blank line for consistency with the code style
Failed to generate code suggestions for PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch
No description provided.