Merge main #2593

bob0005 · 2024-12-24T10:32:38Z

No description provided.

* fix weight config * fix realms limit * add structures to bridge * feedback

… next

…ption

vercel · 2024-12-24T10:32:41Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
eternum	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 24, 2024 10:48am
eternum-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 24, 2024 10:48am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
eternum-landing	⬜️ Ignored (Inspect)	Visit Preview		Dec 24, 2024 10:48am

coderabbitai · 2024-12-24T10:32:44Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

mentatbot

This PR includes several notable changes:

Upgrades Cartridge connector and controller packages from 0.5.6 to 0.5.7
Removes Wonder Lords production rate adjustment
Adds decimal places to resource displays for better precision
Improves error handling in resource transfers
Removes Lords filter from resource selection
Adds NotValue filter to exclude zero-member guilds

While most changes appear to be improvements, the removal of Wonder Lords production adjustment and Lords filter could significantly impact gameplay mechanics and should be verified if intentional.

Thanks for using MentatBot. Give comments a 👍 or 👎 to help me improve!

mentatbot · 2024-12-24T10:33:38Z

client/src/dojo/modelManager/ResourceManager.ts

@@ -204,14 +204,6 @@ export class ResourceManager {



The removal of Wonder Lords production rate adjustment (10% rate) appears to be a significant gameplay change. Was this removal intentional? This could impact game balance for Wonder owners.

mentatbot · 2024-12-24T10:33:38Z

client/src/ui/components/trading/SelectResources.tsx

@@ -27,7 +27,6 @@ export const SelectResources = ({
  const orderedResources = useMemo(() => {


The removal of the Lords filter means Lords can now be selected as a resource. Please verify if this change was intentional as it could affect trading mechanics.

github-actions · 2024-12-24T10:34:23Z

Failed to generate code suggestions for PR

aymericdelab and others added 11 commits December 22, 2024 17:34

fix realms limit (#2583)

143f2d5

* fix weight config * fix realms limit * add structures to bridge * feedback

Merge branch 'main' of https://github.com/BibliothecaDAO/eternum into…

14042d0

… next

sync armies fix (#2585)

e0c23e4

remove lords filter (#2588)

d70eb4a

Fix decimals in transfer (#2589)

b07a075

filter dead guilds (#2587)

b60f1aa

Merge branch 'main' into next

7b4e6a8

bump controller version

6600efe

Fix market lords consumption for wonders

60c6a2c

Merge pull request #2591 from BibliothecaDAO/bump-controller

73bfb9b

Merge pull request #2592 from BibliothecaDAO/fix/wonders-lords-consum…

2ad8780

…ption

mentatbot bot reviewed Dec 24, 2024

View reviewed changes

Merge branch 'main' into next

3b90c91

vercel bot deployed to Preview – eternum December 24, 2024 10:46 View deployment

vercel bot deployed to Preview – eternum-docs December 24, 2024 10:48 View deployment

ponderingdemocritus merged commit b2c0ce3 into main Dec 24, 2024
25 of 33 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge main #2593

Merge main #2593

bob0005 commented Dec 24, 2024

vercel bot commented Dec 24, 2024 •

edited

Loading

coderabbitai bot commented Dec 24, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

mentatbot bot left a comment

mentatbot bot Dec 24, 2024

mentatbot bot Dec 24, 2024

github-actions bot commented Dec 24, 2024

		@@ -27,7 +27,6 @@ export const SelectResources = ({
		const orderedResources = useMemo(() => {

Merge main #2593

Merge main #2593

Conversation

bob0005 commented Dec 24, 2024

vercel bot commented Dec 24, 2024 • edited Loading

coderabbitai bot commented Dec 24, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

mentatbot bot left a comment

Choose a reason for hiding this comment

mentatbot bot Dec 24, 2024

Choose a reason for hiding this comment

mentatbot bot Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 24, 2024

vercel bot commented Dec 24, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)