fix guildmembers fetching

[bob0005]

Summary by CodeRabbit

• Bug Fixes

  • Improved the player retrieval process in guilds by refining the query to focus on guild membership.

• Refactor

  • Updated the logic within the useGuilds hook for better accuracy in fetching players associated with a guild.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
eternum	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 20, 2024 10:29am
eternum-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 20, 2024 10:29am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
eternum-landing	⬜️ Ignored (Inspect)	Visit Preview		Dec 20, 2024 10:29am

[coderabbitai]

Walkthrough

The pull request introduces a modification in the useGuilds hook, specifically updating the query mechanism for retrieving players within a guild. The change shifts from using the Guild component to the GuildMember component when querying player associations, potentially reflecting an updated approach to tracking guild membership and player relationships.

Changes

File	Change Summary
client/src/hooks/helpers/useGuilds.tsx	Updated getPlayerListInGuild function query from HasValue(Guild, { entity_id: guild_entity_id }) to HasValue(GuildMember, { guild_entity_id: guild_entity_id })

Poem

🐰 In realms of code where rabbits hop and play,
A query shifts its path in a subtle way
From Guild to Member, a tiny dance
Of data's elegant, nimble stance
Membership tracked with newfound grace 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mentatbot]

You are out of MentatBot reviews. Your usage will refresh December 23 at 08:00 AM.

[github-actions]

Failed to generate code suggestions for PR

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

client/src/hooks/helpers/useGuilds.tsx (1)

287-287: LGTM! Consider optimizing the query order.

The change correctly fixes guild member fetching by querying the GuildMember component directly. This is more precise and consistent with how membership is tracked elsewhere in the codebase.

For a minor optimization, consider reordering the query conditions to filter by the most specific criterion first:

-      runQuery([Has(AddressName), Has(GuildMember), HasValue(GuildMember, { guild_entity_id: guild_entity_id })]),
+      runQuery([HasValue(GuildMember, { guild_entity_id: guild_entity_id }), Has(GuildMember), Has(AddressName)]),

This way, the query first filters by the specific guild_entity_id, potentially reducing the initial set of entities to check.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 60fe5bd and 1e1b6f3.

📒 Files selected for processing (1)

• client/src/hooks/helpers/useGuilds.tsx (1 hunks)