-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert #2533
revert #2533
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Failed to generate code suggestions for PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request simplifies the getEntities
function by removing retry and error handling logic. While this makes the code cleaner, it potentially compromises the ability to handle and recover from errors effectively. Consider whether this aligns with the overall error handling strategy of the application.
Thanks for using MentatBot. Give comments a 👍 or 👎 to help me improve!
// on hexception -> fetch below queries based on entityID | ||
|
||
// background sync after load -> | ||
|
||
export const getEntities = async <S extends Schema>( | ||
client: ToriiClient, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of retry logic simplifies the code but reduces resilience to transient failures. Consider documenting the rationale behind this change or exploring alternative error handling strategies.
if (retries >= maxRetries) { | ||
throw new Error(`Failed to fetch entities after ${maxRetries} retries`); | ||
} | ||
const entities = await client.getEntities({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing error handling and logging may lead to less visibility in case of failures. It might be beneficial to maintain some form of logging to monitor and debug issues effectively.
No description provided.