Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphql data fetching #2516

Merged
merged 10 commits into from
Dec 22, 2024
Merged

Graphql data fetching #2516

merged 10 commits into from
Dec 22, 2024

Conversation

RedBeardEth
Copy link
Contributor

@RedBeardEth RedBeardEth commented Dec 15, 2024

Disables Dojo entity sync
Converts querying required for bridge to graphql

Summary by CodeRabbit

  • New Features

    • Introduced new GraphQL queries: GET_CAPACITY_SPEED_CONFIG, GET_ETERNUM_ENTITY_OWNERS, GET_ENTITY_DISTANCE, and GET_ENTITIES_RESOURCES.
    • Added a custom hook useDonkeyArrivals for managing donkey arrival data.
  • Improvements

    • Enhanced resource balance retrieval with the new useResourceBalance hook.
    • Streamlined data handling in several components to improve performance and clarity.
  • Bug Fixes

    • Adjusted logic for handling player realms and resource management across multiple components.
  • Documentation

    • Updated import statements for various queries to reflect new data sources.

Copy link

vercel bot commented Dec 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eternum ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2024 0:33am
eternum-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2024 0:33am
eternum-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2024 0:33am

Copy link
Contributor

coderabbitai bot commented Dec 15, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces comprehensive updates to the Eternum landing application, focusing on GraphQL schema modifications, resource management, and data fetching mechanisms. The changes span multiple components and hooks, updating how resources, donkeys, and realm data are retrieved and processed. Key modifications include transitioning to a more flexible query-based approach, enhancing type safety, and streamlining data retrieval processes across the application.

Changes

File Change Summary
landing/.env.production Updated VITE_PUBLIC_TORII endpoint from https://eternum.glihm.xyz to https://api.cartridge.gg/x/eternum-prod/torii
landing/codegen.ts Modified GraphQL schema endpoint from https://api.cartridge.gg/x/realms-world-03/torii to https://api.cartridge.gg/x/sepolia-rc-18/torii
landing/schema.graphql Extensive schema updates, including new types, modified query methods, and expanded entity definitions
landing/src/components/modules/* Updated resource balance retrieval, donkey arrival handling, and realm data processing across multiple components
landing/src/hooks/helpers/* Refactored resource and entity retrieval hooks, introducing new query-based approaches
landing/src/hooks/query/* Added new GraphQL queries for capacity config, entity owners, positions, and resources

Sequence Diagram

sequenceDiagram
    participant Client
    participant GraphQLEndpoint
    participant ResourceHook
    participant EntityHook

    Client->>ResourceHook: Request resource balance
    ResourceHook->>GraphQLEndpoint: Execute GET_ENTITIES_RESOURCES
    GraphQLEndpoint-->>ResourceHook: Return resource data
    ResourceHook-->>Client: Provide balanced resource information

    Client->>EntityHook: Request entity information
    EntityHook->>GraphQLEndpoint: Execute GET_ETERNUM_OWNER_REALM_IDS
    GraphQLEndpoint-->>EntityHook: Return realm data
    EntityHook-->>Client: Provide entity details
Loading

Possibly related PRs

Suggested Reviewers

  • bob0005

Poem

🐰 Hop, hop, through the GraphQL maze,
Queries dancing in a digital haze.
Resources flow, donkeys take flight,
Eternum's schema shines so bright!
Code refactored with rabbit's delight! 🌈

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4b9145 and 7ff7001.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (24)
  • landing/.env.production (1 hunks)
  • landing/codegen.ts (1 hunks)
  • landing/schema.graphql (17 hunks)
  • landing/src/components/modules/bridge-in.tsx (11 hunks)
  • landing/src/components/modules/bridge-out-step-1.tsx (7 hunks)
  • landing/src/components/modules/bridge-out-step-2.tsx (8 hunks)
  • landing/src/components/modules/realm-mint-dialog.tsx (1 hunks)
  • landing/src/components/modules/swap-panel.tsx (1 hunks)
  • landing/src/components/ui/SelectResources.tsx (7 hunks)
  • landing/src/components/ui/utils/utils.ts (1 hunks)
  • landing/src/dojo/setup.ts (5 hunks)
  • landing/src/hooks/gql/fragment-masking.ts (1 hunks)
  • landing/src/hooks/gql/gql.ts (2 hunks)
  • landing/src/hooks/gql/index.ts (1 hunks)
  • landing/src/hooks/helpers/useDonkeyArrivals.tsx (1 hunks)
  • landing/src/hooks/helpers/useEntities.tsx (1 hunks)
  • landing/src/hooks/helpers/useResources.tsx (1 hunks)
  • landing/src/hooks/query/capacityConfig.tsx (1 hunks)
  • landing/src/hooks/query/entityOwners.tsx (1 hunks)
  • landing/src/hooks/query/position.tsx (1 hunks)
  • landing/src/hooks/query/resources.tsx (1 hunks)
  • landing/src/hooks/useTravel.tsx (1 hunks)
  • landing/src/routes/mint.lazy.tsx (1 hunks)
  • landing/src/routes/season-passes.lazy.tsx (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

mentatbot bot commented Dec 15, 2024

You are out of MentatBot reviews. Your usage will refresh December 16 at 08:00 AM.

Copy link

Failed to generate code suggestions for PR

@RedBeardEth RedBeardEth merged commit 792d852 into next Dec 22, 2024
22 of 29 checks passed
@RedBeardEth RedBeardEth deleted the bridge branch December 22, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant