-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify army movement #2488
clarify army movement #2488
Conversation
rvorias
commented
Dec 13, 2024
•
edited
Loading
edited
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
WalkthroughThe changes in the documentation focus on clarifying the mechanics of army movement within the game. The section on "Army Types" has been revised to specify the conditions under which armies can move, particularly regarding stamina and food requirements. Additionally, a new explanation about storage limitations and exploration has been included. The descriptions of movement traits for specific units remain unchanged, and the overall structure of the document is preserved. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
docs/pages/mechanics/military/units.mdx (1)
71-72
: Great clarification of movement mechanics!The split into separate points makes it much clearer that:
- Movement is blocked by stamina depletion or food shortage
- Storage only prevents exploration but allows returning home
This distinction is important for players to understand their options when storage is full.
Consider adding a brief example to illustrate this mechanic, such as:
- Armies have limited storage and cannot explore if storage is full, but they can retrace back to the home realm to unload + - Example: An army with full storage at coordinates (10,10) can't move to (11,10) to explore, but can move back towards their realm at (0,0)
Failed to generate code suggestions for PR |