Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify army movement #2488

Merged
merged 1 commit into from
Dec 13, 2024
Merged

clarify army movement #2488

merged 1 commit into from
Dec 13, 2024

Conversation

rvorias
Copy link
Contributor

@rvorias rvorias commented Dec 13, 2024

- Armies have limited storage and cannot move if storage is full, stamina is depleted or there is not enough food at the
  home realm
+++- Armies can't move if their stamina is depleted or there is not enough food at the home realm
+++- Armies have limited storage and cannot explore if storage is full, but they can retrace back to the home realm to unload

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eternum ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 8:44pm
eternum-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 8:44pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
eternum-landing ⬜️ Ignored (Inspect) Dec 13, 2024 8:44pm

Copy link
Contributor

coderabbitai bot commented Dec 13, 2024

Walkthrough

The changes in the documentation focus on clarifying the mechanics of army movement within the game. The section on "Army Types" has been revised to specify the conditions under which armies can move, particularly regarding stamina and food requirements. Additionally, a new explanation about storage limitations and exploration has been included. The descriptions of movement traits for specific units remain unchanged, and the overall structure of the document is preserved.

Changes

File Path Change Summary
docs/pages/mechanics/military/units.mdx Updated "Army Types" section to clarify movement conditions; added explanation about storage limits.

Poem

In fields of battle, armies roam,
With food and stamina, they find their home.
Storage full? They cannot explore,
But back to the realm, they’ll unload once more.
With knights and paladins, brave and true,
The mechanics of movement, now clearer for you! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
docs/pages/mechanics/military/units.mdx (1)

71-72: Great clarification of movement mechanics!

The split into separate points makes it much clearer that:

  1. Movement is blocked by stamina depletion or food shortage
  2. Storage only prevents exploration but allows returning home

This distinction is important for players to understand their options when storage is full.

Consider adding a brief example to illustrate this mechanic, such as:

 - Armies have limited storage and cannot explore if storage is full, but they can retrace back to the home realm to unload
+   - Example: An army with full storage at coordinates (10,10) can't move to (11,10) to explore, but can move back towards their realm at (0,0)
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 43eca3b and d887529.

📒 Files selected for processing (1)
  • docs/pages/mechanics/military/units.mdx (1 hunks)

Copy link

Failed to generate code suggestions for PR

@ponderingdemocritus ponderingdemocritus merged commit 251ad42 into next Dec 13, 2024
23 of 29 checks passed
@ponderingdemocritus ponderingdemocritus deleted the docs/army-movement branch December 13, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants