Fix/lingering labels

[bob0005]

Closes #2475
Closes #2453

Summary by CodeRabbit

• New Features

  • Enhanced tooltip management during fade-in transitions.
  • Improved interaction logic for army movement on the Worldmap by clearing hovered hex state.

• Bug Fixes

  • Resolved lingering visual cues after right-click actions involving army movement.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
eternum	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 0:29am
eternum-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 0:29am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
eternum-landing	⬜️ Ignored (Inspect)	Visit Preview		Dec 13, 2024 0:29am

[coderabbitai]

Walkthrough

The changes in this pull request involve modifications to the TransitionManager and WorldmapScene classes. In TransitionManager, the fadeIn method has been updated to include a call to setTooltip(null) alongside disabling the loading screen. The WorldmapScene class has been altered to clear the hovered hex state within the onHexagonRightClick method when an army movement occurs. These updates aim to enhance state management and interaction logic in the respective components.

Changes

File	Change Summary
client/src/three/components/TransitionManager.tsx	Updated fadeIn() method to include setTooltip(null) in addition to disabling the loading screen.
client/src/three/scenes/Worldmap.ts	Modified onHexagonRightClick() method to clear the hovered hex state when an army movement is executed.

Assessment against linked issues

Objective	Addressed	Explanation
Action info still showing after click (#2475)	✅
Building label on worldmap (#2453)	❌	No changes related to building labels made.

Possibly related PRs

• only 1 army sound #2129: This PR modifies the WorldmapScene class in Worldmap.ts, focusing on sound playback logic, related to interaction logic.
• Remove automatic hex selection #2323: This PR enhances state management and user interactions in WorldmapScene, potentially relevant to overall functionality but not directly linked to TransitionManager.

Poem

In the world of maps and fades,
A tooltip's light now gently fades.
With clicks, the hexagons clear their way,
As armies move and play all day.
A dance of states, both bright and new,
In code we hop, with joy we brew! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bedc490 and 648f7e6.

📒 Files selected for processing (2)

• client/src/three/components/TransitionManager.tsx (1 hunks)
• client/src/three/scenes/Worldmap.ts (1 hunks)

🔇 Additional comments (2)

client/src/three/components/TransitionManager.tsx (1)

18-20: LGTM! Good cleanup of tooltip state.

The addition of setTooltip(null) ensures that tooltips are properly cleared during transitions, preventing any lingering UI elements.

client/src/three/scenes/Worldmap.ts (1)

336-336: LGTM! Good cleanup of hover state.

The addition of this.state.updateHoveredHex(null) ensures that the hovered hex state is properly cleared when army movement occurs, preventing any lingering UI elements.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mentatbot]

You are out of MentatBot reviews. Your usage will refresh December 16 at 08:00 AM.

[github-actions]

Failed to generate code suggestions for PR