fix bank pos

[aymericdelab]

Summary by CodeRabbit

• Chores
  • Enhanced code readability in the World component by restructuring subscription state updates for clarity.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
eternum	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 7:43am
eternum-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 7:43am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
eternum-landing	⬜️ Ignored (Inspect)	Visit Preview		Dec 13, 2024 7:43am

[coderabbitai]

Walkthrough

The changes in this pull request focus on the World component located in client/src/ui/layouts/World.tsx. The primary modification involves restructuring the setSubscriptions function calls within the useEffect hooks to improve code readability. The updates to the subscriptions state are now formatted across multiple lines, enhancing clarity while maintaining the original functionality. Error handling for asynchronous operations remains unchanged, ensuring that the component's control flow and logic are preserved.

Changes

File	Change Summary
client/src/ui/layouts/World.tsx	Restructured setSubscriptions calls in useEffect hooks for improved readability; no functional changes made.

Possibly related PRs

• ✨ Add sub to all player structures #2442: The changes in this PR directly modify the World component in client/src/ui/layouts/World.tsx, enhancing subscription management and state handling, which is closely related to the restructuring of setSubscriptions in the main PR.

Suggested reviewers

• edisontim
• ponderingdemocritus

Poem

In the World where code does play,
Clarity shines in a bright new way.
Subscriptions now neatly aligned,
Readability is what we find.
With each line clear, the logic stays,
A happy code, in joyful arrays! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mentatbot]

You are out of MentatBot reviews. Your usage will refresh December 16 at 08:00 AM.

[github-actions]

Failed to generate code suggestions for PR

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

client/src/ui/layouts/World.tsx (1)

135-139: LGTM! Consider improving error handling.

The multi-line formatting improves readability. However, consider enhancing the error handling for the subsequent async operations.

Consider this pattern for more robust error handling:

 const fetch = async () => {
+  const operations = [
+    {
+      task: () => addToSubscription(
+        dojo.network.toriiClient,
+        dojo.network.contractComponents as any,
+        structureEntityId.toString(),
+        { x: position?.x || 0, y: position?.y || 0 },
+      ),
+      name: 'structure subscription'
+    },
+    {
+      task: () => addToSubscription(
+        dojo.network.toriiClient,
+        dojo.network.contractComponents as any,
+        ADMIN_BANK_ENTITY_ID.toString(),
+      ),
+      name: 'bank subscription'
+    }
+  ];
+
   try {
-    await addToSubscription(
-      dojo.network.toriiClient,
-      dojo.network.contractComponents as any,
-      structureEntityId.toString(),
-      { x: position?.x || 0, y: position?.y || 0 },
-    );
-
-    await addToSubscription(
-      dojo.network.toriiClient,
-      dojo.network.contractComponents as any,
-      ADMIN_BANK_ENTITY_ID.toString(),
-    );
+    await Promise.all(operations.map(async ({ task, name }) => {
+      try {
+        await task();
+      } catch (error) {
+        console.error(`Failed to add ${name}:`, error);
+        throw error;
+      }
+    }));
   } catch (error) {
-    console.error("Fetch failed", error);
+    // Handle the error appropriately (e.g., show user feedback)
   } finally {
     setWorldLoading(false);
   }

This approach:

• Runs subscriptions in parallel for better performance
• Provides detailed error reporting for each operation
• Maintains atomic success/failure for the entire operation

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4572c5c and 8f19af1.

📒 Files selected for processing (1)

• client/src/ui/layouts/World.tsx (1 hunks)