Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise limits and remove chat #2435

Merged
merged 1 commit into from
Dec 11, 2024
Merged

raise limits and remove chat #2435

merged 1 commit into from
Dec 11, 2024

Conversation

edisontim
Copy link
Collaborator

@edisontim edisontim commented Dec 11, 2024

Summary by CodeRabbit

  • New Features

    • Increased timeout values for synchronization processes, allowing for longer wait times for fetching entities and events.
  • Bug Fixes

    • Removed the Chat component from the navigation layout, improving the user interface for mobile and desktop views.

Copy link
Contributor

coderabbitai bot commented Dec 11, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces modifications to the setup function in client/src/dojo/setup.ts by increasing the timeout values for the getSyncEntities and getSyncEvents functions. Additionally, the Chat component's rendering logic in client/src/ui/modules/navigation/LeftNavigationModule.tsx has been commented out, preventing it from being displayed in the UI. These changes primarily focus on adjusting synchronization timeout settings and altering the visibility of the Chat component without affecting other functionalities.

Changes

File Path Change Summary
client/src/dojo/setup.ts Increased timeout for getSyncEntities from 10_000 to 20_000 and for getSyncEvents from 20_000 to 40_000.
client/src/ui/modules/navigation/LeftNavigationModule.tsx Commented out the rendering logic for the Chat component, removing it from the UI layout.

Possibly related PRs

  • feat: add countdown backdrop to client page #2383: The changes in this PR involve modifications to the DojoContext.tsx file, which includes the addition of a CountdownTimer component that may relate to synchronization processes similar to those in the setup function of the main PR, particularly in terms of managing timing and loading states.

Suggested reviewers

  • aymericdelab
  • bob0005

🐇 In the code we hop and play,
Adjusting time in a clever way.
The chat's now quiet, tucked away,
For smoother sync, we’ll save the day!
With each new change, we leap and sway! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 764b5c6 and 1ff6775.

📒 Files selected for processing (2)
  • client/src/dojo/setup.ts (1 hunks)
  • client/src/ui/modules/navigation/LeftNavigationModule.tsx (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
eternum-landing ⬜️ Ignored (Inspect) Dec 11, 2024 5:31pm

Copy link
Contributor

mentatbot bot commented Dec 11, 2024

You are out of MentatBot reviews. Your usage will refresh December 16 at 08:00 AM.

@bob0005 bob0005 merged commit abcce38 into next Dec 11, 2024
4 of 9 checks passed
@bob0005 bob0005 deleted the fix/remove-chat-raise-limit branch December 11, 2024 17:32
bob0005 pushed a commit that referenced this pull request Dec 11, 2024
* raise limits and remove chat (#2435)

* loading page loading itmes (#2436)

---------

Co-authored-by: tedison <[email protected]>
Copy link

Failed to generate code suggestions for PR

edisontim added a commit that referenced this pull request Dec 12, 2024
* Add confirmation step to destroy building

* raise limits and remove chat (#2435)

* loading page loading itmes (#2436)

* loaf-opti

* buildings

* load

* push config

* loading

* fix for 0 donkey bridge, base manifest on chain env

* tiles

* merge

* do sync

* bank

* market

* bump

* queries

* reintroduce syncing and fetching

* sync and get happening again

* working multi bridge out step 2, fix transaction success states

* tiles

* remove logging

* memo

* world

* set loading state

* chunk

* coords

* as

* bunk

* bridge styling

* update

* update dojo version

* update dojo sync

* Fix hyperstructures

* fix

* add back chat

* a

* llint

* ✨ Add sub to all player structures

* fix(social): get name from address directly

* chore: add has not settled realm yet

* undefined if no realm found

* pretty

* fix: trade history crash

* 🐛 Fix

* config

* add realm select border animation

* hovered frag mine

* hs cost (#2443)

* hs cost

* fix deposit arrival

* update lock

* load

* Fix/army stamina (#2448)

* Fix current tick values in nextBlockTimestamp

* lint

* Remove quest UI while syncing (#2449)

* Remove quest UI while syncing

* Add quest load animation

* Raschel-dev (#2447)

* hs cost

* fix deposit arrival

* update lock

* fix hs crash

* building cost config

* fix namespace

* remove resource cost syncing

* added production

* fix costs

* add upgrade

* trigger

* remove events

* fix tile

* fixes

* remove loading

* fix: transfer view styling bug (#2451)

* Fix social tribe crash (#2450)

* fix build

* fix market

---------

Co-authored-by: Bob <[email protected]>
Co-authored-by: tedison <[email protected]>
Co-authored-by: ponderingdemocritus <[email protected]>
Co-authored-by: tedison <[email protected]>
Co-authored-by: RedBeardEth <[email protected]>
Co-authored-by: Loaf <[email protected]>
Co-authored-by: bal7hazar <[email protected]>
Co-authored-by: Nasr <[email protected]>
Co-authored-by: Larko <[email protected]>
Co-authored-by: 0x1337 <[email protected]>
Co-authored-by: Bob <[email protected]>
Co-authored-by: zabanyat.eth <[email protected]>
aymericdelab added a commit that referenced this pull request Dec 12, 2024
* Add confirmation step to destroy building

* raise limits and remove chat (#2435)

* loading page loading itmes (#2436)

* loaf-opti

* buildings

* load

* push config

* loading

* fix for 0 donkey bridge, base manifest on chain env

* tiles

* merge

* do sync

* bank

* market

* bump

* queries

* reintroduce syncing and fetching

* sync and get happening again

* working multi bridge out step 2, fix transaction success states

* tiles

* remove logging

* memo

* world

* set loading state

* chunk

* coords

* as

* bunk

* bridge styling

* update

* update dojo version

* update dojo sync

* Fix hyperstructures

* fix

* add back chat

* a

* llint

* ✨ Add sub to all player structures

* fix(social): get name from address directly

* chore: add has not settled realm yet

* undefined if no realm found

* pretty

* fix: trade history crash

* 🐛 Fix

* config

* add realm select border animation

* hovered frag mine

* hs cost (#2443)

* hs cost

* fix deposit arrival

* update lock

* load

* Fix/army stamina (#2448)

* Fix current tick values in nextBlockTimestamp

* lint

* Remove quest UI while syncing (#2449)

* Remove quest UI while syncing

* Add quest load animation

* Raschel-dev (#2447)

* hs cost

* fix deposit arrival

* update lock

* fix hs crash

* building cost config

* fix namespace

* remove resource cost syncing

* added production

* fix costs

* add upgrade

* trigger

* remove events

* fix tile

* fixes

* remove loading

* fix: transfer view styling bug (#2451)

* Fix social tribe crash (#2450)

* fix build

* fix market

* feat: optimise event messages (#2455)

* optimize events

* fix getSyncEvents composite

* small fixes

---------

Co-authored-by: Bob <[email protected]>
Co-authored-by: ponderingdemocritus <[email protected]>
Co-authored-by: RedBeardEth <[email protected]>
Co-authored-by: Loaf <[email protected]>
Co-authored-by: aymericdelab <[email protected]>
Co-authored-by: bal7hazar <[email protected]>
Co-authored-by: Nasr <[email protected]>
Co-authored-by: Larko <[email protected]>
Co-authored-by: 0x1337 <[email protected]>
Co-authored-by: raschel <[email protected]>
Co-authored-by: Bob <[email protected]>
Co-authored-by: zabanyat.eth <[email protected]>
aymericdelab added a commit that referenced this pull request Dec 12, 2024
* Add confirmation step to destroy building

* raise limits and remove chat (#2435)

* loading page loading itmes (#2436)

* loaf-opti

* buildings

* load

* push config

* loading

* fix for 0 donkey bridge, base manifest on chain env

* tiles

* merge

* do sync

* bank

* market

* bump

* queries

* reintroduce syncing and fetching

* sync and get happening again

* working multi bridge out step 2, fix transaction success states

* tiles

* remove logging

* memo

* world

* set loading state

* chunk

* coords

* as

* bunk

* bridge styling

* update

* update dojo version

* update dojo sync

* Fix hyperstructures

* fix

* add back chat

* a

* llint

* ✨ Add sub to all player structures

* fix(social): get name from address directly

* chore: add has not settled realm yet

* undefined if no realm found

* pretty

* fix: trade history crash

* 🐛 Fix

* config

* add realm select border animation

* hovered frag mine

* hs cost (#2443)

* hs cost

* fix deposit arrival

* update lock

* load

* Fix/army stamina (#2448)

* Fix current tick values in nextBlockTimestamp

* lint

* Remove quest UI while syncing (#2449)

* Remove quest UI while syncing

* Add quest load animation

* Raschel-dev (#2447)

* hs cost

* fix deposit arrival

* update lock

* fix hs crash

* building cost config

* fix namespace

* remove resource cost syncing

* added production

* fix costs

* add upgrade

* trigger

* remove events

* fix tile

* fixes

* remove loading

* fix: transfer view styling bug (#2451)

* Fix social tribe crash (#2450)

* fix build

* fix market

* add lords to controller on landing

* feat: optimise event messages (#2455)

* optimize events

* fix getSyncEvents composite

* small fixes

* 🐛 Fix mainnet torii cfg

* Fix laggy social search

* landing page + quest + inventory (#2461)

* update inventory

* more discrete quest loading

* fix landing page sync

---------

Co-authored-by: Bob <[email protected]>
Co-authored-by: tedison <[email protected]>
Co-authored-by: ponderingdemocritus <[email protected]>
Co-authored-by: tedison <[email protected]>
Co-authored-by: RedBeardEth <[email protected]>
Co-authored-by: Loaf <[email protected]>
Co-authored-by: bal7hazar <[email protected]>
Co-authored-by: Nasr <[email protected]>
Co-authored-by: Larko <[email protected]>
Co-authored-by: 0x1337 <[email protected]>
Co-authored-by: Bob <[email protected]>
Co-authored-by: zabanyat.eth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants