update min army

[spaghettiOnToast]

Updated min army size for attack and pillage

Summary by CodeRabbit

• New Features
  • Updated documentation on military unit mechanics, including new requirements for attacking armies.
  • Expanded details on army creation, movement, and operational limits.
• Documentation
  • Clarified conditions for engaging in offensive actions and constraints on army movement.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
eternum	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 11, 2024 1:43pm
eternum-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 11, 2024 1:43pm
eternum-landing	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 11, 2024 1:43pm

[coderabbitai]

Walkthrough

The changes involve updates to the documentation regarding military units in the game, specifically addressing the mechanics of army movement and engagement. A new requirement mandates that attacking armies must consist of at least 100 troops to initiate attacks and pillaging. The document also clarifies the conditions for creating attacking armies, movement restrictions based on storage and stamina, and the operational limits of armies.

Changes

File Path	Change Summary
docs/pages/mechanics/military/units.mdx	Updated to include new details on military unit mechanics, including troop requirements for attacks, army creation limits, movement restrictions, and operational constraints.

Possibly related PRs

• fix battle #2422: This PR introduces a method to ensure that armies have a minimum troop count of 100 before engaging in battles or pillaging, directly relating to the new requirement introduced in the main PR regarding attacking armies.

🐇 In the realm where armies grow,
A hundred troops must now bestow,
To raid and pillage, they must unite,
Exploring lands both day and night.
With stamina and food in check,
Our bunnies march, what the heck! 🥕

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mentatbot]

You are out of MentatBot reviews. Your usage will refresh December 16 at 08:00 AM.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

docs/pages/mechanics/military/units.mdx (1)

67-67: Improve wording conciseness

Consider simplifying the phrase for better readability.

-Armies must have 100 troops in order to attack and pillage
+Armies must have 100 troops to attack and pillage

🧰 Tools

🪛 LanguageTool

[style] ~67-~67: Consider a shorter alternative to avoid wordiness.
Context: ...g Army** - Armies must have 100 troops in order to attack and pillage - Three attacking ar...

(IN_ORDER_TO_PREMIUM)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 54f1955 and e58751c.

📒 Files selected for processing (1)

• docs/pages/mechanics/military/units.mdx (1 hunks)

🧰 Additional context used

🪛 LanguageTool

docs/pages/mechanics/military/units.mdx

[style] ~67-~67: Consider a shorter alternative to avoid wordiness.
Context: ...g Army** - Armies must have 100 troops in order to attack and pillage - Three attacking ar...

(IN_ORDER_TO_PREMIUM)

🔇 Additional comments (1)

docs/pages/mechanics/military/units.mdx (1)

67-67: Verify minimum army size requirement and add error handling details

The new 100 troops requirement is a significant gameplay mechanic. Consider adding:

1. The rationale behind choosing 100 as the minimum
2. What happens when players attempt to attack/pillage with fewer troops
3. Whether this applies to joining existing battles

Let's verify if this value is referenced elsewhere in the codebase:

🧰 Tools

🪛 LanguageTool

[style] ~67-~67: Consider a shorter alternative to avoid wordiness.
Context: ...g Army** - Armies must have 100 troops in order to attack and pillage - Three attacking ar...

(IN_ORDER_TO_PREMIUM)