Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update earthern shard name, fix travel time on bridge #2416

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

RedBeardEth
Copy link
Contributor

@RedBeardEth RedBeardEth commented Dec 11, 2024

Summary by CodeRabbit

  • New Features

    • Updated environment variable configurations for improved API access.
    • Enhanced modal functionality to allow uninitialized acceptance of terms.
  • Bug Fixes

    • Adjusted key names in resource address mappings for consistency.
  • Style

    • Improved layout and spacing in the BridgeFees component for better user experience.

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eternum 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 11:58am
eternum-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 11:58am
eternum-landing 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 11:58am

Copy link
Contributor

coderabbitai bot commented Dec 11, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve updates to environment variable configurations in the landing/.env.production file, specifically modifying the VITE_PUBLIC_TORII and VITE_PUBLIC_TORII_RELAY variables. Additionally, the resource name "EARTHENSHARD" has been renamed to "ANCIENT_FRAGMENT" across multiple JSON files, including resource_addresses.json in local, mainnet, and sepolia directories. The BridgeFees component has also been adjusted for layout changes, while the EternumConditionsModal component's state management has been enhanced to accommodate an uninitialized state. Lastly, a new component key has been added in the setup function.

Changes

File Path Change Summary
landing/.env.production Updated VITE_PUBLIC_TORII and VITE_PUBLIC_TORII_RELAY environment variables.
landing/public/resource_addresses/local/resource_addresses.json Renamed resource key from "EARTHENSHARD" to "ANCIENT_FRAGMENT".
landing/public/resource_addresses/mainnet/resource_addresses.json Renamed resource key from "EARTHENSHARD" to "ANCIENT_FRAGMENT".
landing/public/resource_addresses/sepolia/resource_addresses.json Renamed resource key from "EARTHENSHARD" to "ANCIENT_FRAGMENT".
landing/src/components/modules/bridge-fees.tsx Adjusted layout by changing class names and adding a separator in the BridgeFees component.
landing/src/components/modules/eternum-conditions-modal.tsx Updated state management in EternumConditionsModal to allow for an uninitialized state.
landing/src/dojo/setup.ts Added "SpeedConfig" to the filteredComponents array in the setup function.

Possibly related PRs

  • env #1973: The changes in the .env.preview file involve updates to the VITE_PUBLIC_TORII and VITE_PUBLIC_TORII_RELAY variables, which are similar to the modifications made to the same variables in the landing/.env.production file in the main PR.
  • Landing/bridge #2324: The modification of the VITE_CLIENT_FEE_RECIPIENT variable in the .env.preview file to VITE_PUBLIC_CLIENT_FEE_RECIPIENT indicates a change in the scope of the variable, which aligns with the focus on environment variable configurations in the main PR.
  • refactor bridge - prepare for main merge #2371: The introduction of the BridgeFees component in this PR relates to the changes in the BridgeIn component in the main PR, as both involve handling fees associated with resource transfers.

Suggested reviewers

  • ponderingdemocritus

🐇 In the land where the data flows,
Variables change, as the rabbit knows.
From "EARTHENSHARD" to "ANCIENT_FRAGMENT" we leap,
With padding adjusted, our layout's neat!
A modal now opens with terms to accept,
In this world of code, our changes are adept! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 3e67ead and 737be60.

📒 Files selected for processing (7)
  • landing/.env.production (1 hunks)
  • landing/public/resource_addresses/local/resource_addresses.json (1 hunks)
  • landing/public/resource_addresses/mainnet/resource_addresses.json (1 hunks)
  • landing/public/resource_addresses/sepolia/resource_addresses.json (1 hunks)
  • landing/src/components/modules/bridge-fees.tsx (2 hunks)
  • landing/src/components/modules/eternum-conditions-modal.tsx (2 hunks)
  • landing/src/dojo/setup.ts (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

mentatbot bot commented Dec 11, 2024

You are out of MentatBot reviews. Your usage will refresh December 16 at 08:00 AM.

@RedBeardEth RedBeardEth merged commit c36f4ad into next Dec 11, 2024
8 of 13 checks passed
@RedBeardEth RedBeardEth deleted the bridge branch December 11, 2024 11:58
Copy link

Failed to generate code suggestions for PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant