Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge UX #2401

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Bridge UX #2401

merged 6 commits into from
Dec 11, 2024

Conversation

RedBeardEth
Copy link
Contributor

@RedBeardEth RedBeardEth commented Dec 11, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced new resource management functionality in the BridgeIn component.
    • Added a new constant for the prize pool leaderboard.
  • Improvements

    • Enhanced UI layout and usability in BridgeOutStep1, BridgeOutStep2, and SwapPanel components.
    • Updated styling for tabs and scrollbar for a more consistent appearance.
  • Bug Fixes

    • Adjusted logic for calculating the lords prize pool to include new leaderboard constant.
  • Documentation

    • Improved comments in the routeTree file for clarity on auto-generated status.
  • Chores

    • Updated environment variables for production settings.

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eternum ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 2:36am
eternum-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 2:36am
eternum-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 2:36am

Copy link
Contributor

coderabbitai bot commented Dec 11, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request includes updates to environment variables in the client/.env.production file, specifically changing the values of VITE_PUBLIC_TORII and VITE_PUBLIC_TORII_RELAY. Additionally, several components in the landing module, such as BridgeIn, BridgeOutStep1, BridgeOutStep2, and SwapPanel, have undergone structural and functional modifications to improve resource management and user interface. A new constant for the prize pool has been added, and the useLords hook has been updated to accept an optional parameter. CSS modifications include changes to custom properties and scrollbar styling.

Changes

File Path Change Summary
client/.env.production Updated VITE_PUBLIC_TORII and VITE_PUBLIC_TORII_RELAY variables.
landing/src/components/modules/bridge-in.tsx Added useLords, useBalance, and divideByPrecision; introduced resourceAddresses state; modified rendering logic with ResourceInputRow.
landing/src/components/modules/bridge-out-step-1.tsx Added SelectSingleResource; removed commented code; reorganized layout with fragments and sticky footer.
landing/src/components/modules/bridge-out-step-2.tsx Removed formatFee; improved layout with a wrapper; updated donkey selection messaging.
landing/src/components/modules/swap-panel.tsx Simplified outer <div>; enhanced styling for TabsContent components.
landing/src/constants.ts Added PRIZE_POOL_INDIVIDUAL_LEADERBOARD constant.
landing/src/hooks/use-lords.tsx Updated useLords to accept an optional disabled parameter.
landing/src/index.css Updated --muted-foreground variable and scrollbar width.
landing/src/routeTree.gen.ts Updated comments for clarity on auto-generated nature.
landing/src/routes/index.lazy.tsx Updated import for prize pool constants and modified calculation logic for "lords prize pool".
landing/tailwind.config.js Added xxs font size configuration.

Possibly related PRs

  • env #1973: Directly modifies environment variables, including VITE_PUBLIC_TORII.
  • Landing/bridge #2324: Renames an environment variable, which is directly related to the changes in the main PR.

Suggested reviewers

  • ponderingdemocritus

Poem

🐰 In the land of code where rabbits play,
New paths are forged, come what may.
With variables changed and layouts bright,
We hop along, our future in sight!
Resource rows and balances in view,
A world of wonders, all fresh and new! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 75dc84e and c1f7bf0.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (11)
  • client/.env.production (1 hunks)
  • landing/src/components/modules/bridge-in.tsx (4 hunks)
  • landing/src/components/modules/bridge-out-step-1.tsx (2 hunks)
  • landing/src/components/modules/bridge-out-step-2.tsx (2 hunks)
  • landing/src/components/modules/swap-panel.tsx (2 hunks)
  • landing/src/constants.ts (1 hunks)
  • landing/src/hooks/use-lords.tsx (2 hunks)
  • landing/src/index.css (2 hunks)
  • landing/src/routeTree.gen.ts (1 hunks)
  • landing/src/routes/index.lazy.tsx (2 hunks)
  • landing/tailwind.config.js (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

mentatbot bot commented Dec 11, 2024

You are out of MentatBot reviews. Your usage will refresh December 16 at 08:00 AM.

Copy link

Failed to generate code suggestions for PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant