-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean/legacy #1146
Merged
Merged
Clean/legacy #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
edisontim
reviewed
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments but lgtm
edisontim
approved these changes
Jul 30, 2024
edisontim
added a commit
that referenced
this pull request
Aug 1, 2024
* contract: limit armies and enable deletion * contracts: delete army if merging kills troop * upgrade to dojov1.0.0-alpha.1 * upgrade to dojov1.0.0-alpha.1 * scarb fmt * update tests * update tests && scarb fmt * update test utils * update test utils * update test utils * update test utils * fix inaccurate winner invariant error * add tool-versions * contracts: basic army create tests * contracts: basic army buy tests * fix reward calculation bug * more combat tests * combat: reward bug fix * scarb fmt * Merge branch 'v1' of https://github.com/BibliothecaDAO/eternum into combat-tests * update workflow * update lockfile * update workflow * update workflow * update lockfile * update lock file * bump to alpha 2 * update to cairo 2.7.0 * contracts: update workflow to print resource usage * update workflow * contracts: use u32 as primary id * contracts: use u32 as primary id in tests * update config and manifests * contracts: optimization: use IntrospectPacked * - remove introspectpacked from models with enum - use id alias more * Clean/legacy (#1146) * Clean legacy code + remove unused exports * add knip command * more cleaning * prettier * Cleanup + add knip CI * fix build * fix knip * rebase main * prettier * fix knip ci * resolve comments * feat: Change to V1 + add type aliases for entity ids (#1148) * Change to V1 + add type aliases for entity ids * Make elements clickable under right and left navigation modules buttons + fix z-index of quests, guilds and leaderboard * scarb fmt * Change bonus_percent to u32 instead of u128 * Address minor PR comments * prettier * knip --------- Co-authored-by: ponderingdemocritus <[email protected]> Co-authored-by: tedison <[email protected]> Co-authored-by: Constantin Wastchenko <[email protected]> Co-authored-by: tedison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.