Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: put 30 seconds as default client time out #39

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Conversation

btfhernandez
Copy link
Contributor

No description provided.

@btfhernandez btfhernandez requested review from a team as code owners February 27, 2024 15:47

if clientTimeOutinSeconds == 0 {
clientTimeOutinSeconds = 30
*retryMaxElapsedTimeMinutes = 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to also check the retryMaxElapsedTimeMinutes

if retryMaxElapsedTimeMinutes == 0 {
retryMaxElapsedTimeMinutes = 2
{

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.


@thejurysays thejurysays merged commit 973db62 into main Feb 27, 2024
7 checks passed
@thejurysays thejurysays deleted the BIPS-16625_2 branch February 27, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants