fix: file download

README.md

@@ -106,6 +106,12 @@ logger, _ := zap.NewProduction()
 // create a zap logger wrapper
 zapLogger := logging.NewZapLogger(logger)
 ```
+## Unit Tests
+```
+go-client-library-passwordsafe\api\authentication> go test
+go-client-library-passwordsafe\api\managed_account> go test
+go-client-library-passwordsafe\api\secrets> go test
+```
 
 ## License
 This software is distributed under the Massachusetts Institute of Technology (MIT) License. See `LICENSE.txt` for more information.

TestClient.go

@@ -33,9 +33,9 @@ func main() {
 	retryMaxElapsedTimeMinutes := 2
 
 	// validate inputs
-	errors_in_inputs := utils.ValidateInputs(clientId, clientSecret, apiUrl, clientTimeOutInSeconds, &separator, verifyCa, zapLogger, certificate, certificateKey)
+	errorsInInputs := utils.ValidateInputs(clientId, clientSecret, apiUrl, clientTimeOutInSeconds, &separator, verifyCa, zapLogger, certificate, certificateKey)
 
-	if errors_in_inputs != nil {
+	if errorsInInputs != nil {
 		return
 	}
 
@@ -61,8 +61,8 @@ func main() {
 	}
 
 	// getting secrets
-	secretList := strings.Split(paths, ",")
-	gotSecrets, _ := secretObj.GetSecrets(secretList, separator)
+	secretPaths := strings.Split(paths, ",")
+	gotSecrets, _ := secretObj.GetSecrets(secretPaths, separator)
 
 	// WARNING: Do not log secrets in production code, the following log statement logs test secrets for testing purposes:
 	zapLogger.Info(fmt.Sprintf("%v", gotSecrets))
@@ -71,7 +71,7 @@ func main() {
 	gotSecret, _ := secretObj.GetSecret("fake/text1", separator)
 
 	// WARNING: Do not log secrets in production code, the following log statement logs test secrets for testing purposes:
-	zapLogger.Info(fmt.Sprintf("%v", gotSecret))
+	zapLogger.Info(fmt.Sprintf("Secret Test: %v", gotSecret))
 
 	// instantiating managed account obj
 	manageAccountObj, _ := managed_accounts.NewManagedAccountObj(*authenticate, zapLogger)

api/secrets/secrets.go

@@ -32,17 +32,17 @@ func NewSecretObj(authentication authentication.AuthenticationObj, logger loggin
 }
 
 // GetSecrets returns secret value for a path and title list.
-func (secretObj *SecretObj) GetSecrets(secretsList []string, separator string) (map[string]string, error) {
+func (secretObj *SecretObj) GetSecrets(secretPaths []string, separator string) (map[string]string, error) {
 	if separator == "" {
 		separator = ""
 	}
-	return secretObj.GetSecretFlow(secretsList, separator)
+	return secretObj.GetSecretFlow(secretPaths, separator)
 }
 
 // GetSecret returns secret value for a specific path and title.
 func (secretObj *SecretObj) GetSecret(secretPath string, separator string) (string, error) {
-	secretList := []string{}
-	secrets, _ := secretObj.GetSecretFlow(append(secretList, secretPath), separator)
+	secretPaths := []string{}
+	secrets, _ := secretObj.GetSecretFlow(append(secretPaths, secretPath), separator)
 	secretValue := secrets[secretPath]
 	return secretValue, nil
 }
@@ -73,9 +73,9 @@ func (secretObj *SecretObj) GetSecretFlow(secretsToRetrieve []string, separator
 			}
 
 			secretDictionary[secretToRetrieve] = fileSecretContent
+		} else {
+			secretDictionary[secretToRetrieve] = secret.Password
 		}
-		secretDictionary[secretToRetrieve] = secret.Password
-
 	}
 
 	return secretDictionary, nil
@@ -126,7 +126,7 @@ func (secretObj *SecretObj) SecretGetSecretByPath(secretPath string, secretTitle
 
 	if len(SecretObjectList) == 0 {
 		scode = 404
-		err = fmt.Errorf("Error %v: StatusCode: %v ", "SecretGetSecretByPath, Secret was not found", scode)
+		err = fmt.Errorf("error %v: StatusCode: %v ", "SecretGetSecretByPath, Secret was not found", scode)
 		return entities.Secret{}, err
 	}
 
@@ -137,7 +137,7 @@ func (secretObj *SecretObj) SecretGetSecretByPath(secretPath string, secretTitle
 // and returns file secret value.
 func (secretObj *SecretObj) SecretGetFileSecret(secretId string, endpointPath string) (string, error) {
 	messageLog := fmt.Sprintf("%v %v", "GET", endpointPath)
-	secretObj.log.Debug(messageLog)
+	secretObj.log.Debug(messageLog + "file/download")
 
 	var body io.ReadCloser
 	var technicalError error

api/secrets/secrets_test.go

@@ -143,7 +143,7 @@ func TestSecretFlow(t *testing.T) {
 				http.NotFound(w, r)
 			}
 		})),
-		response: "credential_in_sub_3_password",
+		response: "fake_password",
 	}
 
 	authenticate.ApiUrl = testConfig.server.URL + "/"
@@ -198,14 +198,14 @@ func TestSecretFlow_SecretNotFound(t *testing.T) {
 				http.NotFound(w, r)
 			}
 		})),
-		response: "Error SecretGetSecretByPath, Secret was not found: StatusCode: 404 ",
+		response: "error SecretGetSecretByPath, Secret was not found: StatusCode: 404 ",
 	}
 
 	authenticate.ApiUrl = testConfig.server.URL + "/"
 	secretObj, _ := NewSecretObj(*authenticate, zapLogger)
 
-	secretList := strings.Split("oauthgrp_nocert/Test1,oauthgrp_nocert/client_id", ",")
-	_, err := secretObj.GetSecretFlow(secretList, "/")
+	secretPaths := strings.Split("oauthgrp_nocert/Test1,oauthgrp_nocert/client_id", ",")
+	_, err := secretObj.GetSecretFlow(secretPaths, "/")
 
 	if err == nil {
 		t.Errorf("Test case Failed: %v", err)