Skip to content

Commit

Permalink
chore: linter, link, typo and formatting fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
ipowellBT committed Feb 27, 2024
1 parent 1734a06 commit 2223390
Show file tree
Hide file tree
Showing 12 changed files with 105 additions and 92 deletions.
4 changes: 2 additions & 2 deletions .frogbot/frogbot-config.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
- params:
- params:
git:
repoName: go-client-library-passwordsafe
branches:
Expand All @@ -8,4 +8,4 @@
failOnSecurityIssues: false
projects:
- workingDirs:
- "."
- "."
2 changes: 1 addition & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ updates:
- package-ecosystem: github-actions
directory: "/"
schedule:
interval: "weekly"
interval: "weekly"
2 changes: 1 addition & 1 deletion .github/release.yaml
Original file line number Diff line number Diff line change
@@ -1 +1 @@
releaseType: simple
releaseType: simple
1 change: 0 additions & 1 deletion .github/settings.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
_extends: .github
repository:
private: false

7 changes: 3 additions & 4 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ jobs:
with:
fetch-depth: 0
ref: ${{ github.head_ref }}


- name: Initialize CodeQL
uses: github/codeql-action/init@v3
Expand All @@ -38,9 +37,9 @@ jobs:

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3

analyze_on_branch:
name: Analyze on branch
name: Analyze on branch
if: ${{ github.actor != 'dependabot[bot]' && ( github.event_name != 'pull_request' && github.event_name != 'pull_request_target' ) }}
runs-on: ubuntu-latest
strategy:
Expand Down Expand Up @@ -69,4 +68,4 @@ jobs:
uses: github/codeql-action/autobuild@v3

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3
uses: github/codeql-action/analyze@v3
6 changes: 3 additions & 3 deletions .github/workflows/frogbot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ jobs:
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}

- name: Set up JFrog
uses: jfrog/setup-jfrog-cli@v4
env:
JF_ENV_1: ${{ secrets.ARTIFACTORY_DEPLOYER }}

- name: Run XRay scan
uses: jfrog/[email protected]
env:
JF_URL: https://beyondtrust.jfrog.io
JF_ACCESS_TOKEN: ${{ secrets.ARTIFACTORY_FROGBOT_TOKEN }}
JF_GIT_TOKEN: ${{ secrets.GITHUB_TOKEN }}
JF_GIT_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6 changes: 3 additions & 3 deletions .github/workflows/golint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
types: [opened, synchronize]
push:
branches:
- main
- main
workflow_dispatch:

permissions:
Expand All @@ -19,8 +19,8 @@ jobs:
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
fetch-depth: 0

- name: Go Lint
uses: golangci/[email protected]
with:
version: v1.54
version: v1.54
24 changes: 12 additions & 12 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
types: [opened, synchronize]
push:
branches:
- main
- main
workflow_dispatch:

permissions:
Expand All @@ -28,7 +28,7 @@ jobs:
- name: Build library
run: |
go build
- name: Run unit tests
run: |
cd api
Expand All @@ -55,14 +55,14 @@ jobs:
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
fetch-depth: 0

- name: Download coverage
uses: actions/download-artifact@v4
with:
name: coverage

- name: SonarQube Scan on PR
if: ${{ github.actor != 'dependabot[bot]' && github.event_name == 'pull_request' }}
if: ${{ github.actor != 'dependabot[bot]' && github.event_name == 'pull_request' }}
uses: sonarsource/sonarqube-scan-action@master
with:
projectBaseDir: .
Expand All @@ -76,9 +76,9 @@ jobs:
env:
SONAR_TOKEN: ${{ env.SONAR_TOKEN }}
SONAR_HOST_URL: https://sonar.dev.beyondtrust.com

- name: SonarQube Scan on branch
if: ${{ github.actor != 'dependabot[bot]' && github.event_name != 'pull_request' }}
if: ${{ github.actor != 'dependabot[bot]' && github.event_name != 'pull_request' }}
uses: sonarsource/sonarqube-scan-action@master
with:
projectBaseDir: .
Expand All @@ -91,12 +91,12 @@ jobs:
SONAR_HOST_URL: https://sonar.dev.beyondtrust.com

- name: SonarQube Quality Gate check
if: ${{ github.actor != 'dependabot[bot]' && inputs.quality_gate_check }}
if: ${{ github.actor != 'dependabot[bot]' }}
uses: sonarsource/sonarqube-quality-gate-action@master
timeout-minutes: 5
env:
SONAR_TOKEN: ${{ env.SONAR_TOKEN }}

x-ray:
needs: [build, sonarqube]
runs-on: ubuntu-latest
Expand All @@ -110,7 +110,7 @@ jobs:
uses: jfrog/[email protected]
env:
JF_ENV_1: ${{ secrets.ARTIFACTORY_DEPLOYER }}

- name: Setting up artifactory
run: |
mkdir go-library-passwordsafe
Expand All @@ -120,8 +120,8 @@ jobs:
with:
name: library
path: go-library-passwordsafe
- name: Send artifacts to Jfrog

- name: Send artifacts to Jfrog
run: |
jfrog rt u "go-library-passwordsafe/*" ${{ env.JFROG_SERVER}}
Expand All @@ -132,4 +132,4 @@ jobs:
jfrog rt build-publish ${{ env.JFROG_CLI_BUILD_NAME }} ${{ env.JFROG_CLI_BUILD_NUMBER }}
- name: Scan Build
run: jfrog rt build-scan ${{ env.JFROG_CLI_BUILD_NAME }} ${{ env.JFROG_CLI_BUILD_NUMBER }}
run: jfrog rt build-scan ${{ env.JFROG_CLI_BUILD_NAME }} ${{ env.JFROG_CLI_BUILD_NUMBER }}
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

#### Bug Fixes

* solve minnor issues and linting issues ([#30](https://github.com/BeyondTrust/go-client-library-passwordsafe/issues/30))
* solve minor issues and linting issues ([#30](https://github.com/BeyondTrust/go-client-library-passwordsafe/issues/30))

### [0.2.0](https://github.com/BeyondTrust/go-client-library-passwordsafe/compare/v0.1.0...v0.2.0) / 2024-02-23

Expand Down
6 changes: 3 additions & 3 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,11 @@ community.
## Attribution
This Code of Conduct is adapted from the Contributor Covenant,
version 2.1, available at
[https://www.contributor-covenant.org/version/2/1/code_of_conduct.html][v2.1].
[v2.1](https://www.contributor-covenant.org/version/2/1/code_of_conduct.html).

Community Impact Guidelines were inspired by
Mozilla's code of conduct enforcement ladder.

For answers to common questions about this code of conduct, see the FAQ at
[https://www.contributor-covenant.org/faq][FAQ]. Translations are available at
[https://www.contributor-covenant.org/translations][translations].
[FAQ](https://www.contributor-covenant.org/faq). Translations are available at
[translations](https://www.contributor-covenant.org/translations).
Loading

0 comments on commit 2223390

Please sign in to comment.