Treat all Constraints and ClippingShapes differently than children wh…

…en propagating collapse Decided to go with the `is` check because it seems like all types of Constraints or ClippingShapes should follow this behavior now and in the future. Diffs= 16cf8082f Treat Constraints, ClippingShapes and DrawRules as special Solo child types (#5897) Co-authored-by: Philip Chung <[email protected]>
BertholdKrevert · Aug 25, 2023 · ffb3fe7 · ffb3fe7
1 parent 42e8de2
commit ffb3fe7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/.rive_head b/.rive_head
@@ -1 +1 @@
-e1b9d360b4ab7a2620f888cb9b4497d253e1da80
+16cf8082fd9a66014305994c736d98cc12d96c73
diff --git a/src/solo.cpp b/src/solo.cpp
@@ -13,12 +13,10 @@ void Solo::propagateCollapse(bool collapse)
         // Some child components shouldn't be considered as part of the solo set
         // as they are more aking to properties of the solo itself. For those
         // components, simply pass on the collapse value of the solo itself.
-        switch (child->coreType())
+        if (child->is<Constraint>() || child->is<ClippingShape>())
         {
-            case ConstraintBase::typeKey:
-            case ClippingShapeBase::typeKey:
-                child->collapse(collapse);
-                continue;
+            child->collapse(collapse);
+            continue;
         }
 
         // This child is part of the solo set so only make it active if it's the
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		e1b9d360b4ab7a2620f888cb9b4497d253e1da80
		16cf8082fd9a66014305994c736d98cc12d96c73