Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zizmor to scan for GHA security problems #320

Merged
merged 17 commits into from
Jan 22, 2025
Merged

Use zizmor to scan for GHA security problems #320

merged 17 commits into from
Jan 22, 2025

Conversation

dfremont
Copy link
Collaborator

Description

Fixes potential security problems flagged by zizmor and runs it in CI.

Issue Link

n/a

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

@dfremont dfremont requested a review from lola831 December 14, 2024 04:07
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (a6e48a2) to head (a7177b8).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
- Coverage   91.35%   91.33%   -0.02%     
==========================================
  Files          54       54              
  Lines       13568    13584      +16     
==========================================
+ Hits        12395    12407      +12     
- Misses       1173     1177       +4     

see 8 files with indirect coverage changes

Copy link
Collaborator Author

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Lola!

Copy link
Collaborator

@lola831 lola831 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good. I also manually tested run-simulators, and it works as expected.

run: |
echo "$PRIVATE_KEY" > private_key && chmod 600 private_key
ssh -o StrictHostKeyChecking=no -i private_key ${USER_NAME}@${HOSTNAME} '
ssh -o StrictHostKeyChecking=no -o SendEnv=GH_REF -i private_key ${USER_NAME}@${HOSTNAME} '
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the method for passing the environment variable into SSH by using SendEnv. I manually ran the run-simulators GitHub workflow action, and it worked as expected.

@lola831 lola831 merged commit 8495cc9 into main Jan 22, 2025
39 of 40 checks passed
@lola831 lola831 deleted the zizmor branch January 22, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants