-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orientation Composition Fixes #241
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 86.13% 86.15% +0.02%
==========================================
Files 144 144
Lines 24938 24983 +45
==========================================
+ Hits 21480 21524 +44
- Misses 3458 3459 +1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Daniel Fremont <[email protected]>
…nic into OrientationFixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I confirmed objects with non-global parent orientations now correctly apply yaw
, etc. in the built-in visualizer and in CARLA (with the appropriate coordinate conversion fixes -- I'll send those separately).
Description
Fixed orientations being composed backwards. Also added several tests and updated some documentation.
Issue Link
N/A
Checklist
pytest
and/or other meansAdditional Notes
N/A