Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orientation Composition Fixes #241

Merged
merged 11 commits into from
Apr 23, 2024
Merged

Orientation Composition Fixes #241

merged 11 commits into from
Apr 23, 2024

Conversation

Eric-Vin
Copy link
Collaborator

Description

Fixed orientations being composed backwards. Also added several tests and updated some documentation.

Issue Link

N/A

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

N/A

@Eric-Vin Eric-Vin changed the title Orientation fixes Orientation Composition Fixes Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.15%. Comparing base (7f018e0) to head (7b2ad85).
Report is 1 commits behind head on main.

Files Patch % Lines
src/scenic/core/vectors.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   86.13%   86.15%   +0.02%     
==========================================
  Files         144      144              
  Lines       24938    24983      +45     
==========================================
+ Hits        21480    21524      +44     
- Misses       3458     3459       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eric-Vin Eric-Vin requested a review from dfremont April 22, 2024 18:42
@Eric-Vin Eric-Vin requested a review from dfremont April 23, 2024 04:21
Copy link
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I confirmed objects with non-global parent orientations now correctly apply yaw, etc. in the built-in visualizer and in CARLA (with the appropriate coordinate conversion fixes -- I'll send those separately).

@dfremont dfremont merged commit 1c49d80 into main Apr 23, 2024
26 checks passed
@dfremont dfremont deleted the OrientationFixes branch April 23, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants