Skip to content

Commit

Permalink
Tweaked angle cutoff values.
Browse files Browse the repository at this point in the history
  • Loading branch information
Eric-Vin committed Dec 13, 2023
1 parent 06f98c3 commit 6404338
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/scenic/core/regions.py
Original file line number Diff line number Diff line change
Expand Up @@ -3591,7 +3591,7 @@ def __init__(
position=Vector(0, 0, 0),
rotation=None,
orientation=None,
angleCutoff=0.001,
angleCutoff=0.017,
tolerance=1e-8,
):
# Bound viewAngles from either side.
Expand Down Expand Up @@ -3621,7 +3621,7 @@ def __init__(
else:
# Case 2
view_region = base_sphere.intersect(
ViewSectionRegion(visibleDistance, viewAngles, angleCutoff)
ViewSectionRegion(visibleDistance, viewAngles)
)

assert view_region is not None
Expand Down
4 changes: 2 additions & 2 deletions tests/core/test_regions.py
Original file line number Diff line number Diff line change
Expand Up @@ -543,9 +543,9 @@ def test_pointset_region():


# ViewRegion tests
H_ANGLES = [0.5, 45, 90, 135, 179.9, 180, 180.1, 225, 270, 315, 359.5, 360]
H_ANGLES = [1.01, 45, 90, 135, 179.99, 180, 180.01, 225, 270, 315, 358.99, 360]

V_ANGLES = [0.5, 45, 90, 135, 179.5, 180]
V_ANGLES = [1.01, 45, 90, 135, 178.99, 180]

VISIBLE_DISTANCES = [1, 25, 50]

Expand Down

0 comments on commit 6404338

Please sign in to comment.