Bugfix: memory leak fixed, that was caused by a listener created by the

"AbstractTabLayoutManagerPane". The listener was never removed properly. Thanks mattbru2 for finding the bug!
Benoker · Jun 4, 2017 · f78688c · f78688c
1 parent 1007a96
commit f78688c
Show file tree

Hide file tree

Showing 12 changed files with 21 additions and 10 deletions.
diff --git a/docking-frames-common/pom.xml b/docking-frames-common/pom.xml
@@ -5,7 +5,7 @@
 	<parent>
 		<groupId>org.dockingframes</groupId>
 		<artifactId>docking-frames-base</artifactId>
-        <version>1.1.2-P19a</version>
+        <version>1.1.2-P19b</version>
 	</parent>
 
 	<artifactId>docking-frames-common</artifactId>

diff --git a/docking-frames-core/changes.txt b/docking-frames-core/changes.txt
@@ -1115,4 +1115,7 @@
 [v1.1.2p19a]
 - Bugfix: when adding an action to an existing dropdown-menu, then the action was always added at the end of the menu
 - Bugfix (provided by Nicolas Roduit): properly read java version specification number of Java 9 (see "DockUI.registerColors")
-- Feature (provided by Nicolas Roduit): new and better translations for various languages
+- Feature (provided by Nicolas Roduit): new and better translations for various languages
+
+[v1.1.2p19b]
+- Bugfix: memory leak fixed, that was caused by a listener created by the "AbstractTabLayoutManagerPane". The listener was never removed properly. Thanks mattbru2 for finding the bug! 
diff --git a/docking-frames-core/pom.xml b/docking-frames-core/pom.xml
@@ -5,7 +5,7 @@
 	<parent>
 		<groupId>org.dockingframes</groupId>
 		<artifactId>docking-frames-base</artifactId>
-        <version>1.1.2-P19a</version>
+        <version>1.1.2-P19b</version>
 	</parent>
 
 	<artifactId>docking-frames-core</artifactId>

diff --git a/docking-frames-core/src/bibliothek/gui/dock/station/stack/tab/AbstractTabLayoutManager.java b/docking-frames-core/src/bibliothek/gui/dock/station/stack/tab/AbstractTabLayoutManager.java
@@ -53,6 +53,7 @@ public void uninstall( TabPane pane ){
 				iterator.remove();
 				pane.removeTabPaneListener( next );
 				destroy( next );
+				next.uninstalled();
 			}
 		}
 	}

diff --git a/...g-frames-core/src/bibliothek/gui/dock/station/stack/tab/AbstractTabLayoutManagerPane.java b/...g-frames-core/src/bibliothek/gui/dock/station/stack/tab/AbstractTabLayoutManagerPane.java
@@ -79,6 +79,13 @@ public void removed( TabPane pane, Dockable dockable ){
 	public void selectionChanged( TabPane pane ){
 		// ignore
 	}
+
+	/**
+	 * Called by the {@link AbstractTabLayoutManager} once this pane is no longer in use.
+	 */
+	public void uninstalled(){
+		useSmallMinimumSize.setProperties( (DockController)null );
+	}
 
 	public void controllerChanged( TabPane pane, DockController controller ){
 		useSmallMinimumSize.setProperties( controller );

diff --git a/docking-frames-core/version b/docking-frames-core/version
@@ -1 +1 @@
-1.1.2-P19a
+1.1.2-P19b
diff --git a/docking-frames-demo-tutorial/pom.xml b/docking-frames-demo-tutorial/pom.xml
@@ -5,7 +5,7 @@
   <parent>
     <groupId>org.dockingframes</groupId>
     <artifactId>docking-frames-base</artifactId>
-    <version>1.1.2-P19a</version>
+    <version>1.1.2-P19b</version>
   </parent>
 
   <artifactId>tutorial</artifactId>

diff --git a/docking-frames-ext-glass/pom.xml b/docking-frames-ext-glass/pom.xml
@@ -6,7 +6,7 @@
 	<parent>
 		<groupId>org.dockingframes</groupId>
 		<artifactId>docking-frames-base</artifactId>
-		<version>1.1.2-P19a</version>
+		<version>1.1.2-P19b</version>
 	</parent>
 
 	<artifactId>docking-frames-ext-glass</artifactId>

diff --git a/docking-frames-ext-toolbar-common/pom.xml b/docking-frames-ext-toolbar-common/pom.xml
@@ -5,7 +5,7 @@
   <parent>
     <groupId>org.dockingframes</groupId>
     <artifactId>docking-frames-base</artifactId>
-    <version>1.1.2-P19a</version>
+    <version>1.1.2-P19b</version>
   </parent>
 
   <artifactId>docking-frames-ext-toolbar-common</artifactId>

diff --git a/docking-frames-ext-toolbar-tutorial/pom.xml b/docking-frames-ext-toolbar-tutorial/pom.xml
@@ -5,7 +5,7 @@
   <parent>
     <groupId>org.dockingframes</groupId>
     <artifactId>docking-frames-base</artifactId>
-    <version>1.1.2-P19a</version>
+    <version>1.1.2-P19b</version>
   </parent>
 
   <artifactId>tutorial-toolbar</artifactId>

diff --git a/docking-frames-ext-toolbar/pom.xml b/docking-frames-ext-toolbar/pom.xml
@@ -5,7 +5,7 @@
   <parent>
     <groupId>org.dockingframes</groupId>
     <artifactId>docking-frames-base</artifactId>
-    <version>1.1.2-P19a</version>
+    <version>1.1.2-P19b</version>
   </parent>
 
   <artifactId>docking-frames-ext-toolbar</artifactId>

diff --git a/pom.xml b/pom.xml
@@ -11,7 +11,7 @@
 
 	<groupId>org.dockingframes</groupId>
 	<artifactId>docking-frames-base</artifactId>
-	<version>1.1.2-P19a</version>
+	<version>1.1.2-P19b</version>
 	<packaging>pom</packaging>
 
 	<modules>