Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added waiting, future and skipped projects #1

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

dfinley
Copy link

@dfinley dfinley commented Aug 29, 2014

I merged some of the code from Arberg's repo as well as addressed an issue with losing connection.

New features added include ignoring tasks with a waiting or future label and skipping projects ending with '*'


This change is Reviewable

@@ -164,13 +184,13 @@ def subProjects(self):
return self._subProjects

def IsIgnored(self):
return self.name.startswith('Someday') or self.name.startswith('List - ')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someday is one of the GTD mailbox.
So prefer to keep it to be closer to what I am used to :)
(but both solution can coexist :) )

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally understand and I like the concept of the somday mailbox, I just happened to name my label 'future'. This is probably getting into personal preference but I'm using ZenToDone (ZTD) instead of GTD, it borrows a lot of the same concepts but varies slightly in implementation. As you said, their's no reason they can't coexist :)

I was interested in underst

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it misses the end, or? :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd... I can't understand why that comment was cut short or where I was going... probably user error.

@BenjaminVanRyseghem
Copy link
Owner

So, what is the next action here :)
It could be nice that instead of doing this PR against master,
you do it against another branch, so I can contribute

@dfinley
Copy link
Author

dfinley commented Aug 31, 2014

That's a good idea, I'm not going to be insulted if you reject my pull request, create another branch and I'll pull reuest to that one.  Or I can name you as a collaborator on mine and then you can work directly on my repo or vice versa.  So many options!In the end building new func on new branches is definitely a better way for both of us to work on this

@BenjaminVanRyseghem
Copy link
Owner

Reviewed 1 of 1 files at r4, 1 of 1 files at r5.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@BenjaminVanRyseghem
Copy link
Owner

Reviewed 1 of 1 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

shadowgate15 referenced this pull request in shadowgate15/automation-todoist-old Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants