Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

need a few lemmas to push through this proof #99

Merged
merged 13 commits into from
Jun 6, 2024
Merged

need a few lemmas to push through this proof #99

merged 13 commits into from
Jun 6, 2024

Conversation

HuStmpHrrr
Copy link
Member

No description provided.

@HuStmpHrrr HuStmpHrrr requested a review from Ailrun June 4, 2024 17:07
Ailrun
Ailrun reviewed Jun 5, 2024
View reviewed changes
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about proofs

theories/Core/Soundness/LogicalRelation/Lemmas.v Outdated Show resolved Hide resolved
theories/Core/Soundness/LogicalRelation/Lemmas.v Outdated Show resolved Hide resolved
theories/Core/Soundness/LogicalRelation/Lemmas.v Outdated Show resolved Hide resolved
HuStmpHrrr
HuStmpHrrr commented Jun 5, 2024
View reviewed changes
theories/Core/Soundness/LogicalRelation/Lemmas.v Show resolved Hide resolved
theories/Core/Syntactic/Corollaries.v Outdated Show resolved Hide resolved
theories/Core/Syntactic/System/Definitions.v Outdated Show resolved Hide resolved
theories/Core/Syntactic/System/Lemmas.v Show resolved Hide resolved
@HuStmpHrrr HuStmpHrrr changed the title [WIP] need a few lemmas to push through this proof need a few lemmas to push through this proof Jun 5, 2024
@HuStmpHrrr
Copy link
Member Author

let's try to merge what I have for now. more lemmas are coming in next PRs.

Ailrun
Ailrun approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this. I think I can refactor some proofs later (so that there are less explicit hypothesis names).

@Ailrun Ailrun merged commit c6e076b into main Jun 6, 2024
2 checks passed
@Ailrun Ailrun deleted the feature/logrel-lemmas2 branch July 12, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ailrun Ailrun Ailrun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Port NbE proof from Agda to Coq
Development

Successfully merging this pull request may close these issues.
2 participants
@HuStmpHrrr @Ailrun