Merge branch 'fix-actionid'

Add a random part in the generated ActionId
BelirafoN · Mar 2, 2020 · 3bfbd18 · 3bfbd18
2 parents 2114629 + 324fe64
commit 3bfbd18
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/lib/AmiClient.js b/lib/AmiClient.js
@@ -317,6 +317,14 @@ class AmiClient extends EventEmitter{
         return true;
     }
 
+    /**
+     *
+     * @private
+     */
+    _random() {
+        return Math.floor(Math.random() * (10 ** 10));
+    }
+
     /**
      *
      * @param prefix
@@ -325,7 +333,7 @@ class AmiClient extends EventEmitter{
      */
     _genActionId(prefix){
         prefix = prefix || '';
-        return `${prefix}${Date.now()}`;
+        return `${prefix}${Date.now()}-${this._random()}`;
     }
 
     /**

diff --git a/test/amiClientTest.js b/test/amiClientTest.js
@@ -577,7 +577,8 @@ describe('Ami Client internal functionality', function(){
             client = new AmiClient({dontDeleteSpecActionId: true});
             client.connect(USERNAME, SECRET, {port: socketOptions.port}).then(() => {
                 client.once('response', response => {
-                    assert.ok(/^--spec_\d{13}$/.test(response.ActionID));
+                    console.log("actionid = ", response.ActionID);
+                    assert.ok(/^--spec_\d{13}-\d{1,10}$/.test(response.ActionID));
                     done();
                 })
                 .action({Action: 'Ping'});