Protobuffer upgrade to match goflow2 v2.2.1 #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goflow2 changed its protobuffer format These changes adapt the new format
goflow2 change the format of kafka messages. To ensure the functionallity of existing 3rd party software a legacy flag was added
flowmessages didnt contain start/end timestamps
debugloop
reviewed
Dec 7, 2024
| @@ -0,0 +1,502 @@ | |||
| // FROM https://github.com/bwNetFlow/flowfilter/ | |||
There was a problem hiding this comment.
But... why? This requires the flowpipeline project to have knowledge about the details of flowfilter's matching. That kinda goes against separation of concerns.
| //go:build linux | ||
| // +build linux | ||
|
|
||
| // based on https://github.com/bwNetFlow/bpf_flowexport/blob/master/packetdump/packetdump.go |
There was a problem hiding this comment.
Same here I guess? The reason we initially kept this outside the repo was that it stays separate and we can leverage any other kind of bpf packet capture. At this point, there should be lots of projects out there that we could use instead of our home-baked solution (I found go-pkt just now for instance)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goflow2 changed its protobuffer format
These changes adapt the new format and introduce a legacy export flag to still support existing applications